Commit Graph

1593 Commits

Author SHA1 Message Date
Liam Girdwood 7ef4ca9175
Merge pull request #558 from libinyang/increase_runtime_memory_on_more_platforms
memory: increase HEAP_RT_COUNT256 size
2018-11-09 09:46:30 +00:00
ArturX Kloniecki 8a7ed10cab Lower size of .text section
Removed 5 parameter trace_event macro implementation.
Removed inline
specifier from __panic function definition.
I've observed, that recent growth of .text section size was caused
by 2 major factors: 2 instances of inlined __panic function
yielding 1.7kB and recent addition of 5 param trace_event
yeilding 0.5kB of used .text. section space.

Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
2018-11-09 09:44:24 +01:00
Liam Girdwood 2f7b57551a
Merge pull request #555 from singalsu/fix_vol_mult_s24_to_s16
Volume: Bug fix for vol_mult_s24_to_s16() function
2018-11-09 08:40:14 +00:00
Libin Yang 7eb36a4f2d memory: increase HEAP_RT_COUNT256 size
This patch increases HEAP_RT_COUNT256 size from 64 to 80 on
cannonlake, icelake and suecreek.

Signed-off-by: Libin Yang <libin.yang@intel.com>
2018-11-09 10:12:39 +08:00
Seppo Ingalsuo f4049bb7d6 Volume: Bug fix for vol_mult_s24_to_s16() function
The previous commit introduced a bug in this volume function. The input
parameter for s24 PCM samples must be int32_t. The bug causes for s24 to
s16 converted audio very low signal level and noise due to overflows.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
2018-11-08 18:36:06 +02:00
Liam Girdwood 9b376d7bd4
Merge pull request #548 from bkokoszx/revert-host-traces
host: trace: revert host traces to fprintf
2018-11-08 14:57:49 +00:00
Liam Girdwood cee5f5f430
Merge pull request #554 from mwierzbix/workaround-build_fail_for_smt_too_big_sof_text
debugability: workaround for SOF_TEXT_SIZE too big with smp enabled
2018-11-08 14:56:53 +00:00
Bartosz Kokoszko e69b42fccb host: trace: revert host traces to fprintf
Host doesn't use trace mechanism - I've reverted
all host traces to simple fprintf.

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
2018-11-08 15:23:26 +01:00
Michal Jerzy Wierzbicki 68bce2514e debugability: workaround for SOF_TEXT_SIZE too big with smp enabled (issue553)
Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
2018-11-08 13:34:22 +01:00
Liam Girdwood 431711c8cb
Merge pull request #543 from mwierzbix/debugability-macro-metaprog-bugfix-varargcount_0_for_parenthesis
preproc: varargscount: bugfix for tokens starting with '(' not being counted
2018-11-08 11:36:26 +00:00
Liam Girdwood 11f27aca1c
Merge pull request #540 from zhuyingjiang/topic/add-manifest-1.5
[RFC]Topic/add 1.5 manifest and rimage
2018-11-08 11:35:26 +00:00
Michał Jerzy Wierzbicki f092d906fc
Merge branch 'master' into debugability-macro-metaprog-bugfix-varargcount_0_for_parenthesis 2018-11-08 12:22:05 +01:00
Zhu Yingjiang 5912e40fe3 change the 1.8 and 1.5 header defines
add comments and change the 1.5 1.8 header defines

Signed-off-by: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
2018-11-08 18:53:29 +08:00
Liam Girdwood 868feb6f78
Merge pull request #549 from libinyang/increase_apl_runtime_memory
memory: apl: increase HEAP_RT_COUNT256 size
2018-11-08 08:49:24 +00:00
Liam Girdwood 3256781a74
Merge pull request #541 from libinyang/init_heap_in_right_way
alloc: fix memory heap initialization
2018-11-08 08:47:56 +00:00
Libin Yang db728a7c11 memory: apl: increase HEAP_RT_COUNT256 size
This patch fixes the memory allocation error for nocodec platform
by increasing HEAP_RT_COUNT256 size

Signed-off-by: Libin Yang <libin.yang@intel.com>
2018-11-08 10:58:09 +08:00
Libin Yang 159f118a99 alloc: fix memory heap initialization
This patch fixes the bug of runtime & buffer memory heap initialization,
and sets the correct base address for each map.

Signed-off-by: Libin Yang <libin.yang@intel.com>
2018-11-08 09:37:06 +08:00
Liam Girdwood 019eadebcf
Merge pull request #530 from akloniex/ids-in-trace
debugability: pipeline and component ids in trace messages
2018-11-07 15:14:28 +00:00
ArturX Kloniecki 42179929d2 debugability: Refactor dai traces to fully utilize trace_event
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
2018-11-07 13:45:56 +01:00
ArturX Kloniecki 8449f24904 debugability: Refactor ipc handler traces to fully utilize trace_event
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
2018-11-07 12:33:16 +01:00
ArturX Kloniecki 1d559f820c debugability: Refactor pipeline traces to fully utilize new trace_event
Implemented set of macros for pipelines to allow reporting of pipeline
and component IDs. Refactor all traces to provide useful, human readible
messages.

Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
2018-11-07 12:33:16 +01:00
ArturX Kloniecki 9af90ce211 debugability: Add components ids to trace_event macros
2 arbitrary IDs may now be passed to specialized versions of
trace_event macro: trace_event_with_ids. Also optimized runtime
stack usage of _trace_event functions.

Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
2018-11-07 12:33:16 +01:00
Liam Girdwood 40c054ab30
Merge pull request #514 from mrajwa/icl_work
DMIC: Enable power for DMIC for ICL platform.
2018-11-06 19:53:10 +00:00
Marcin Rajwa 18baa47a9d DMIC: Enable power for DMIC for ICL platform.
Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
2018-11-06 17:34:17 +01:00
Liam Girdwood 528870ac94
Merge pull request #528 from singalsu/fix_volume_generic_overflow
Volume: Fix overflow in s16 and s24 output conversions
2018-11-06 14:18:22 +00:00
Liam Girdwood 054a338d8f
Merge pull request #545 from xiulipan/pr/dockersh
Scripts update
2018-11-06 14:05:58 +00:00
Pan Xiuli fbb4053af0 scripts: only update platform that will be build
Keep other platform binary and lst files

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
2018-11-06 15:39:52 +08:00
Pan Xiuli 0ca1c79d06 scripts: docker: remove -t flag
t flag is used to allocate a pseudo-TTY, but in some cases pseudo-tty is
not support. Removed for more useage.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
2018-11-06 14:51:26 +08:00
Michal Jerzy Wierzbicki 87dad4adc5 preproc: META_COUNT_VARARGS_BEFORE_COMPILE: bugfix for tokens starting with parenthesis not being counted
; also introduced unit tests to check the issue

Signed-off-by: Michal Jerzy Wierzbicki <michalx.wierzbicki@linux.intel.com>
2018-11-06 02:38:16 +01:00
Zhu Yingjiang f1c5a15c8a rimage: add build scripts to build 1.5 image
add to build scripts and Makefiles to build firmware binary
for kbl and skl

Signed-off-by: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
2018-11-05 18:36:03 +08:00
Zhu Yingjiang 328c4ea6e5 rimage: add 1.5 rimage package API
add API for making 1.5 rimage binary

Signed-off-by: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
2018-11-05 18:36:02 +08:00
Zhu Yingjiang 7e0a9d8b6f rimage: add 1.5 rimage defines
add 1.5 rimage defines for skl and kbl

Signed-off-by: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
2018-11-05 18:36:02 +08:00
Zhu Yingjiang 5d6a43c278 rimage: manifest: add manifest APIs
add the 1.5 manifest operation APIs

Signed-off-by: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
2018-11-05 18:36:02 +08:00
Zhu Yingjiang dc17f286b9 rimage: manifest: add 1.5 manifest define
add 1.5 manifest structure define, macro define, KBL and
SKL 1.5 manifest defines

Signed-off-by: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
2018-11-05 18:35:48 +08:00
Zhu Yingjiang f89a4a5418 rimage: manifest: rename old manifest to 1.8
rename old API and comments print info to 1.8, as for add
1.5 manifest.

Signed-off-by: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
2018-11-05 16:19:49 +08:00
Liam Girdwood 33e4b99351
Merge pull request #455 from mwierzbix/debugability
debugability: macro metaprogramming refactor
2018-11-02 16:00:02 +00:00
Seppo Ingalsuo 4fa9a7b386 Volume: Fix overflow in s16 and s24 output conversions
The problem could be heard with extremely loud music content. The
32x32 saturating multiply function works for 32 bit output but
the result will overflow when less number of bits are used from output.

This patch adds to format.h rounded 32x32 multiply inline functions for
saturated s24 and s16 formats. The generic volume function is updated
to utilize them and the code structure is cleaned for easier maintenance
and simpler look.

The format.h file is cleaned up with function parameter indents and
remove of redundant code in saturate function.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
2018-11-02 15:51:37 +02:00
Michal Jerzy Wierzbicki b284ac32b5 debugability: Macro Metaprogramming Refactor
Added macro functions to make repetitive, nearly identical functions more maintainable via metaprogramming. They generate code in pre-compile, conceptually similar to C++17 if-constexpr.  sof/trace, host/trace: rewrote _trace_event/d+ functions using preproc.h. test/cmocka/include/test_group_generator: rewrote macros to not conflict with new ones. Added unit tests to check whether more advanced and less obvious macros do in fact work.

Signed-off-by: Michal Jerzy Wierzbicki <michalx.wierzbicki@linux.intel.com>
2018-11-02 11:44:31 +01:00
Liam Girdwood 43da16962d
Merge pull request #519 from ranj063/dmic_prm
dmic: fix mem alloc for dmic params
2018-10-31 18:38:30 +00:00
Ranjani Sridharan 25d0f01d03 dmic: fix mem alloc for dmic params
The dmic params struct should be allocated in RZONE_RUNTIME
instead of RZONE_SYS so that it can be freed. This
fixes the DSP panic caused while it is freed after setting
the DMIC config.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
2018-10-31 10:27:08 -07:00
Liam Girdwood 66bd59b080
Merge pull request #518 from thesofproject/topic/lrg/allocator-fixes
allocator: Improve rfree() debug and trace
2018-10-30 19:27:52 +00:00
Liam Girdwood 6b45d5c81a
Merge pull request #512 from akloniex/extract-fw_version
debugability: extract fw_version and copy it to .ldc file
2018-10-30 19:25:12 +00:00
ArturX Kloniecki 0f3f9c0807 rimage: debugability: include fw_version in .ldc file
Extract fw_version from fw_ready section of elf and include it in
header of .ldc file to allow verification by sof-logger.

Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
2018-10-30 12:21:56 +01:00
Liam Girdwood 04b1ce4883
Merge pull request #517 from mmaka1/hda-size-fixed
dma: hda: Free size computation fixed
2018-10-29 16:50:22 +00:00
Liam Girdwood 62c5684ed6 allocator: Improve rfree() debug and trace
System heap is one time allocate only meant for init and not for freeing.
Panic if someone attempts to free system heap.

Provide pointers and cpu core ID for any failures in trace .

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
2018-10-29 16:37:25 +00:00
Marcin Maka d7a6b50457 dma: hda: Free size computation fixed
Wrong result may impact pause/release command handlers running unaligned
with work queue tick.

Signed-off-by: Marcin Maka <marcin.maka@linux.intel.com>
2018-10-29 15:49:12 +01:00
ArturX Kloniecki f59e7061d3 debugability: extract fw_ready message to separate section
This is done in order to place fw_version, part of fw_ready message,
in both .ri and .ldc files, for later verification of compatibility
of trace logs reported by dsp with .ldc file parsed together by logger.

Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
2018-10-29 12:54:38 +01:00
Liam Girdwood e10126306a
Merge pull request #513 from thesofproject/revert-505-link-dma-id
Revert "hda: set correct link dma channel"
2018-10-26 16:15:23 +01:00
Liam Girdwood 26bfbfd699
Revert "hda: set correct link dma channel" 2018-10-26 16:14:31 +01:00
Liam Girdwood 3f3d7c0473
Merge pull request #505 from RanderWang/link-dma-id
hda: set correct link dma channel
2018-10-25 16:43:06 +01:00