Add a volume get() callback alongside the set() callback. validate the
number of channels for both get/set.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Need to add a reply to ctrl data, since the structure can be returned
to host e.g. during kcontrol get() calls.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Make SRC, EQ and DAI use the new buffer size and reset position API
calls rather than manually resetting and sizing the buffer.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
This patch adds a the comp_set_state() used for
the mandatory pipeline commands, START, STOP, PAUSE and RELEASE. It also
updates the cmd method in existing components to use comp_set_state().
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Add new APIs to allow components to easily resize, reset and clear
buffers. Update host, mixer and volume to use them.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
The error in computing block length in copy() function is fixed. It
caused SRC to use unnecessarily long blocks with some rates and fail
to execute within available buffer size. The input and output block
length is now computed in initization. Sample rates support mask bit
for 7350 Hz is removed also.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
There can be some confusion over mailbox naming wrt to in/out and up/down
naming with respect to DSP or host context.
Rename the mailboxes to imply either host initiated or DSP initiated IPC
so that it's obvious to driver and FW engineers which is the correct
mailbox to use.
This change also simplifies the IPC command replies by returning 1 if
the command function creates the reply message otherwise a generic
reply is used.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
ALSA can get confused during preload if we send an XRUN (i.e. before ALSA
has triggered).
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
This patch fixes the return value from the preload_downstream() call in
pipeline_params()
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
To add support for different types of heap memory, here it will:
1. add handle for RFLAGS_DMA which will allocate DMA buffer blocks
if exist;
2. refine free_block, which will free blocks of runtime heap,
general buffer heap, or dma buffer heap.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Tested-by: Zhang Keqiao <keqiao.zhang@intel.com>
Add an ABI header to be pre-pended to all binary blobs or bespoke
component data structures that will be passed from host to DSP component
or vice versa (i.e via binary kcontrols).
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Make sure we validate all config and params variables and complain
if there are omissions or errors.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Balance the heap block map size out to better fit real world usage by
reducing small blocks to create extra larger blocks.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Make the host API and IPC to set and get component runtime data and values
generic with no bespoke commands at the IPC level.
Create a generic structure that descibes the type and size of data and
whether that data is appended to the IPC message or is available to
be DMAed from host.
Update the components to use the new structure. Some components like
SRC, tone and tone still require some work to export thier ABI.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
This patch adds to ipc.h enabling for two new components to read and
write test vectors via file I/O. They are specific to test bench usage
on development computer only and are not real SOF components. This update
avoids need to edit this file for test bench build.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch fixes issues in setting up the tone generator for correct
sample rate and channels number. Component IPC was missing latest needed
changes. The buffers handling issue is fixed. Obsolete commented code is
removed.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
These conversion filters are no more used and will be replaced later with
new. The deletion is because the stop-band spec was changed from 0.51xFs
to 0.50xFs (no intentional aliasing of transition band) so the file
names of new default high-quality filters will be with different filename.
The filter spec is appended to file name to differentiate different
bandwidth filters for same rates fraction.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch fixes bugs in sink and source buffers handling and adds
support for short coefficient type to save RAM in platforms with less
space such as BYT. The patch introduces also a RAM saving minimum
conversions set between 16, 44.1, and 48 kHz. A new possible rate 18.9 kHz
was added to supported rates indication bits. SRC filters quality is also
adjusted for lower default performance. The higher performance will need
>16bit coefficients usage. The larger conversion set and 32 bit
filter coefficients can be easily restored with the SRC tools in rimage.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Current definitions are missing 12 and 64 kHz, have
typos (11250, 22500), list a weird 40kHz and don't
have extension capabilities for non-standard rates
Before we create ABI problems with the Linux kernel, let's add all
the sampling frequencies needed before we submit stuff upstream
(the same list needs to be reflected in the kernel include/uapi)
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Improve support for I2S and DSP modes alongside using topology data to
define the mode configuration. Add trace errors to reject any unsupported
configurations.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Some components have multiple sources/sink and the correct host side
component must be used when installing params. Make sure the correct
component is used here by tracking the previous component and passing it
to the params installation.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Messages starting at offset 1 remove any ambiguity over whether the
message has been constructed correctly.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Complain loudly in trace if we have components overruning or underruning
buffers. Components should check buffer free/avail before use.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Perform a check in the copy() function to make sure there is enough
data to copy to/from host buffers.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Add an XRUN handler into the pipeline to report bag overrun and underrun
from component buffers to the host. An XRUN on a component will now cause
a IPC XRUN message to each PCM interface source/sink to the component.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Liam Girdwood