Commit Graph

16 Commits

Author SHA1 Message Date
Marc Herbert 0061953a59 .github/sparse-zephyr: add -DCONFIG_MINIMAL_LIBC to avoid picolibc
Add a sparse-specific workaround for the incompatibility with
picolibc (the new Zephyr default)
https://github.com/zephyrproject-rtos/zephyr/issues/63003

Also fix comment in commit 2a9473a17b ("app/prj.conf: disable PICOLIBC
with CONFIG_MINIMAL_LIBC=y"): we don't need to disable PICOLIBC
_everywhere_; we only need to disable it when using sparse.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2023-09-27 14:00:10 +01:00
Marc Herbert 1cc4a1f31e .github: add LNL compilation
Because now we can.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2023-05-25 14:28:26 +03:00
Andrey Borisovich 38f3f5d411 workflows: sparse-zephyr upgraded runner OS to Ubuntu 22.04
Runner OS for the Zephyr workflow had been updated to Ubuntu 22.04,
so upgrading this workflow too.

Signed-off-by: Andrey Borisovich <andrey.borisovich@intel.com>
2023-05-20 01:45:42 +03:00
Marc Herbert 179f23331e .github/sparse-zephyr: switch to newer -DZEPHYR_SCA_VARIANT=sparse
-DSPARSE=y still works but has been deprecated for a while.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2023-05-17 12:59:25 +03:00
Marc Herbert 30f4c8c972 .github/sparse-zephyr.yml: delete obsolete REAL_CC magic
This hasn't been required since Zephyr commit 91902c5fd4db ("cmake: add
sparse support to the new SCA infrastructure")

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2023-05-17 12:59:25 +03:00
Guennadi Liakhovetski f772b39e4d sparse: use CONFIG_LOG_USE_VLA=n
Sparse output is spammed with "Variable length array" warnings from
Zephyr logging system. The use of VLAs there can be disabled via
Kconfig. Do that to avoid exceeding sparse's warning maximum and
losing important warnings.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
2023-04-19 14:57:55 +03:00
Marc Herbert 11441d8540 zephyr/docker-run.sh: hardcode zephyr-build img to Zephyr SDK 0.15.2
Windows has always been hardcoded to 0.15.2 in .github Actions.

Fixes the compare-linux-windows check that just started to fail in daily
build https://github.com/thesofproject/sof/actions/runs/4400264770

The ":latest" zephyr-build image was just upgraded to the Zephyr SDK
0.16.0-rc1
https://hub.docker.com/layers/zephyrprojectrtos/zephyr-build/latest/images/sha256-91ef9e556aa2a6b5ee5397536e6c441b87fbaef82b9dfc0d12287c39d884d0af?context=explore

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2023-03-13 21:59:42 +00:00
Marc Herbert 0a835bdb41 .github/sparse-zephyr: add missing workflow_call to fix daily tests
Fixes commit 98b4625a0d (".github/daily-tests.yml: add
sparse-zephyr.yml") and daily tests which just started failing as
found by @aborisovich in
https://github.com/thesofproject/sof/actions/runs/4333619550 and
others (thanks!).

Signed-off-by: Marc Herbert <marc.herbert@gmail.com>
2023-03-06 12:06:09 +00:00
Marc Herbert 0929af4f8c .github/zephyr: replace "TODO: cache docker pull" comment with a link
Caching `docker pull` does not work for size and other reasons, add a
link to the failed experiment.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2023-01-18 13:58:58 +00:00
Marc Herbert 0658767b72 .github/sparse-zephyr: docker pull in a separate step
This saves a lot of scrolling in the next, most popular build step.

Missed in previous commit 52223eba2d (".github/zephyr: docker pull in
a separate step")

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2023-01-04 13:51:19 +02:00
Marc Herbert 6516f907aa sparse: pass platform argument to error filter script
So we can make adjust the warnings based on the platform.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2022-12-12 12:05:26 +00:00
Marc Herbert 2aa9527d0a .github/sparse: use --pristine
--pristine makes no difference for github but it's a good for anyone
trying to reproduce results and copying the command.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2022-12-12 12:05:26 +00:00
Marc Herbert 04e63a90eb .github/sparse-zephyr: build and use our own sparse branch
We need urgent fixes like
`xtensa: switch to little endianness`
https://marc.info/?l=linux-sparse&m=166861736724543
and others.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2022-11-22 09:19:45 +00:00
Marc Herbert 14b2f89bd4 .github/sparse-zephyr: align Ubuntu version with zephyr-build
Safer to have nested containers identical to each other, will help share
binaries.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2022-11-22 09:19:45 +00:00
Marc Herbert 51310587f0 .github/sparse-zephyr: show full log first, then filtered sparse issues
Implement Guennadi's idea in #6590

Discarding all the output is too confusing.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2022-11-22 09:19:45 +00:00
Marc Herbert edb98071f8 .github: move sparse job to a separate workflow
Zero code change, pure move to a new file.

Similarity is not a very strong reason for the sparse job to be in the same
file as regular Zephyr compilation.

Unlike plain Zephyr compilation, the sparse job is very much a "work in
progress" which is currently failing all the time. Moving it to a
different file/workflow provides more configuration flexibility.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2022-11-18 10:49:20 +00:00