From fe690316e1b2537bfcbb4e9efb5333d7dec73e7f Mon Sep 17 00:00:00 2001 From: Tomasz Leman Date: Fri, 1 Mar 2024 14:54:23 +0100 Subject: [PATCH] zephyr: pm_runtime: Remove outdated TODO comment Clean up an incorrect TODO comment in the power management runtime policy. The removed comment suggested the need for substates to handle cases where power gating (PG) is enabled and clock gating (CG) is disabled. However, this is not accurate because: - Enabling PG when CG is not allowed is not feasible; entering PG could inadvertently gate the clock even if CG prevent is active. - Substates are no longer required as clock gating is now always enabled. This change clarifies the power management behavior and removes confusion around the handling of power and clock gating. Signed-off-by: Tomasz Leman --- zephyr/lib/pm_runtime.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/zephyr/lib/pm_runtime.c b/zephyr/lib/pm_runtime.c index 99a23c549..6b46969ad 100644 --- a/zephyr/lib/pm_runtime.c +++ b/zephyr/lib/pm_runtime.c @@ -56,9 +56,6 @@ const struct pm_state_info *pm_policy_next_state(uint8_t cpu, int32_t ticks) if (ticks == K_TICKS_FOREVER || (ticks >= (min_residency + exit_latency))) { - /* TODO: PM_STATE_RUNTIME_IDLE requires substates to be defined - * to handle case with enabled PG andf disabled CG. - */ tr_dbg(&power_tr, "transition to state %x (min_residency = %u, exit_latency = %u)", state->state, min_residency, exit_latency); return state;