OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

codec_adapter: remove unnecessary goto's in module_init() 

Remove the goto's and return the appropriate values right away.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
This commit is contained in:
Ranjani Sridharan 2022-01-10 14:00:21 -08:00 committed by Liam Girdwood
parent 9ba96e2c4a
commit fe04bad091
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/audio/codec_adapter/codec/generic.c
View File

@ -111,16 +111,16 @@ int module_init(struct comp_dev *dev, struct module_interface *interface)
if (!interface) {
comp_err(dev, "module_init(): could not find module interface for module id %x",
module_id);
ret = -EIO;
goto out;
} else if (!interface->init || !interface->prepare ||
!interface->process || !interface->apply_config ||
!interface->reset || !interface->free) {
return -EIO;
}
if (!interface->init || !interface->prepare || !interface->process ||
!interface->apply_config || !interface->reset || !interface->free) {
comp_err(dev, "module_init(): module %x is missing mandatory interfaces",
module_id);
ret = -EIO;
goto out;
return -EIO;
}
/* Assign interface */
md->ops = interface;
/* Init memory list */
@ -131,12 +131,12 @@ int module_init(struct comp_dev *dev, struct module_interface *interface)
if (ret) {
comp_err(dev, "module_init() error %d: module specific init failed, module_id %x",
ret, module_id);
goto out;
return ret;
}
comp_info(dev, "module_init() done");
md->state = MODULE_INITIALIZED;
out:
return ret;
}