OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

src/arch/xtensa/CMakeLists.txt: drop bogus, non-portable -Wl,-EL 

As already discussed in commit bcbcec79e5 ("cmake: drop
binutils-specific '-Wl,-EL' option") and commit ee58fef921
("smex/cmake: move -Wl,EL option to target_linker_options() for clang")
and their corresponding reviews on GitHub, this binutils-specific,
endianness option makes no difference and is causing clang compatibility
issues. It's now getting in the way of #9351 "Add the new platform
ACP_7_0".

I ran `./scripts/docker-run.sh ./scripts/xtensa-build-all.sh -a` with
and without it and there was absolutely zero binary difference.

I was added in 2019 by giant commit e0ba98d21a ("cmake: add CMakeLists
for firmware build") without any rationale of why it would be needed.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This commit is contained in:
Marc Herbert 2024-08-07 16:31:06 +00:00 committed by Kai Vehmanen
parent 3f873a655e
commit ee5efdf5b9
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/arch/xtensa/CMakeLists.txt
View File

@ -123,7 +123,6 @@ target_compile_options(sof_options INTERFACE
$<$<COMPILE_LANGUAGE:C>:
-${optimization_flag} -g
-Wall -Werror
-Wl,-EL
-Wmissing-prototypes
-Wpointer-arith
${XTENSA_C_FLAGS}