From edb2c600542c785ec353928656dc26c7c7735871 Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Thu, 9 Apr 2020 09:36:27 -0700 Subject: [PATCH] CI: Travis: disable host-testbench as long as it ignores errors See https://github.com/thesofproject/sof/issues/2752 host-testbench.sh exits with success 0 when tests fail. Random, recent, all green example in PR #2751: https://travis-ci.org/github/thesofproject/sof/jobs/672996210 is green but: eqiir test failed! I didn't even have to spend time to search for this example, I only looked at the most recent PR. Ignoring failures is the very worst type of validation issue because it makes everyone think everything is OK when it's not. Hides regressions. Signed-off-by: Marc Herbert --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index 0877d0893..ff4044f79 100644 --- a/.travis.yml +++ b/.travis.yml @@ -68,6 +68,9 @@ jobs: - stage: testbench + # Disabled for as long as host-testbench.sh ignores failures, see + # https://github.com/thesofproject/sof/issues/2752 + if: false before_install: *docker-pull-sof script: - ./scripts/docker-run.sh ./scripts/build-tools.sh -t &> /dev/null