OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

checkpatch: --ignore C99_COMMENT_TOLERANCE 

Let's not waste considerable time in code reviews with silly problems
computers can solve.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This commit is contained in:
Marc Herbert 2021-03-30 22:51:42 +00:00 committed by Liam Girdwood
parent fa38c34a7a
commit eb459078f3
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.github/workflows/shallow_checkpatch.yml vendored
View File

@ -19,8 +19,11 @@ jobs:
runs-on: ubuntu-20.04 runs-on: ubuntu-20.04
env: env:
PR_NUM: ${{github.event.number}} PR_NUM: ${{github.event.number}}
# TODO: reduce duplication with scripts/sof-*-commit-hook.sh
# thanks to either some .conf file or some wrapper script
CHK_CMD_OPTS: --ignore UNKNOWN_COMMIT_ID --codespell --codespellfile CHK_CMD_OPTS: --ignore UNKNOWN_COMMIT_ID --codespell --codespellfile
/usr/lib/python3/dist-packages/codespell_lib/data/dictionary.txt /usr/lib/python3/dist-packages/codespell_lib/data/dictionary.txt
--ignore C99_COMMENT_TOLERANCE
steps: steps:
# depth 2 so: # depth 2 so:
# ^1. we can show the Subject of the current target branch tip # ^1. we can show the Subject of the current target branch tip

6
scripts/sof-post-commit-hook.sh
View File

@ -3,4 +3,8 @@
# Copyright(c) 2018 Intel Corporation. All rights reserved. # Copyright(c) 2018 Intel Corporation. All rights reserved.
set -e set -e
exec git show --format=email HEAD | ./scripts/checkpatch.pl --no-tree --strict --codespell # TODO: reduce duplication with scripts/sof-pre-commit-hook.sh
# and with .github/workflows/ with either some .conf file
# or some wrapper script
exec git show --format=email HEAD |
./scripts/checkpatch.pl --no-tree --strict --codespell --ignore C99_COMMENT_TOLERANCE