OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

rimage: Remove unused 'image' argument in elf_find_section() 

Unused arguments shouldn't be passed to function because it
makes code messy.

Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
This commit is contained in:
Karol Trzcinski 2020-03-27 10:51:15 +01:00 committed by Liam Girdwood
parent c4701c7664
commit e433e87865
3 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/elf.c
View File

@ -76,7 +76,7 @@ static int elf_read_sections(struct image *image, struct module *module,
module->bss_end = 0;
} else {
/* find manifest module data */
module->bss_index = elf_find_section(image, module, ".bss");
module->bss_index = elf_find_section(module, ".bss");
if (module->bss_index < 0)
return module->bss_index;
}
@ -464,11 +464,10 @@ int elf_validate_modules(struct image *image)
return 0;
}
int elf_find_section(struct image *image, struct module *module,
const char *name)
int elf_find_section(const struct module *module, const char *name)
{
Elf32_Ehdr *hdr = &module->hdr;
Elf32_Shdr *section, *s;
const Elf32_Shdr *section, *s;
char *buffer;
size_t count;
int ret, i;
@ -569,7 +568,7 @@ int elf_parse_module(struct image *image, int module_index, const char *name)
/* check limits */
elf_module_limits(image, module);
elf_find_section(image, module, "");
elf_find_section(module, "");
fprintf(stdout, " module: input size %d (0x%x) bytes %d sections\n",
module->fw_size, module->fw_size, module->num_sections);

3
src/include/rimage/rimage.h
View File

@ -176,8 +176,7 @@ int elf_parse_module(struct image *image, int module_index, const char *name);
void elf_free_module(struct image *image, int module_index);
int elf_is_rom(struct image *image, Elf32_Shdr *section);
int elf_validate_modules(struct image *image);
int elf_find_section(struct image *image, struct module *module,
const char *name);
int elf_find_section(const struct module *module, const char *name);
int elf_validate_section(struct image *image, struct module *module,
Elf32_Shdr *section, int index);

2
src/manifest.c
View File

@ -230,7 +230,7 @@ static int man_get_module_manifest(struct image *image, struct module *module,
fprintf(stdout, "Module Write: %s\n", module->elf_file);
/* find manifest module data */
man_section_idx = elf_find_section(image, module, ".module");
man_section_idx = elf_find_section(module, ".module");
if (man_section_idx < 0)
return -EINVAL;