OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

sparse: add __sparse_cache annotations to buffer locking functions 

buffer_acquire() and buffer_release() convert between cached and
uncached addresses. Add the sparse __sparse_cache annotation to them to
track down any API misuses.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
This commit is contained in:
Guennadi Liakhovetski 2022-02-09 12:58:05 +01:00 committed by Liam Girdwood
parent aba5f9ae37
commit a85dbaf592
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/include/sof/audio/buffer.h
View File

@ -216,14 +216,15 @@ static inline void buffer_stream_writeback(struct comp_buffer *buffer, uint32_t
audio_stream_writeback(&buffer->stream, bytes); audio_stream_writeback(&buffer->stream, bytes);
} }
__must_check static inline struct comp_buffer *buffer_acquire(struct comp_buffer *buffer) __must_check static inline struct comp_buffer __sparse_cache *buffer_acquire(
struct comp_buffer *buffer)
{ {
struct coherent *c = coherent_acquire_thread(&buffer->c, sizeof(*buffer)); struct coherent __sparse_cache *c = coherent_acquire_thread(&buffer->c, sizeof(*buffer));
return container_of(c, struct comp_buffer, c); return container_of(c, struct comp_buffer, c);
} }
static inline struct comp_buffer *buffer_release(struct comp_buffer *buffer) static inline struct comp_buffer *buffer_release(struct comp_buffer __sparse_cache *buffer)
{ {
struct coherent *c = coherent_release_thread(&buffer->c, sizeof(*buffer)); struct coherent *c = coherent_release_thread(&buffer->c, sizeof(*buffer));
@ -232,15 +233,15 @@ static inline struct comp_buffer *buffer_release(struct comp_buffer *buffer)
static inline void buffer_reset_pos(struct comp_buffer *buffer, void *data) static inline void buffer_reset_pos(struct comp_buffer *buffer, void *data)
{ {
buffer = buffer_acquire(buffer); struct comp_buffer __sparse_cache *buffer_c = buffer_acquire(buffer);
/* reset rw pointers and avail/free bytes counters */ /* reset rw pointers and avail/free bytes counters */
audio_stream_reset(&buffer->stream); audio_stream_reset(&buffer_c->stream);
/* clear buffer contents */ /* clear buffer contents */
buffer_zero(buffer); buffer_zero(buffer_c);
buffer = buffer_release(buffer); buffer_release(buffer_c);
} }
static inline void buffer_init(struct comp_buffer *buffer, uint32_t size, uint32_t caps) static inline void buffer_init(struct comp_buffer *buffer, uint32_t size, uint32_t caps)
@ -253,11 +254,11 @@ static inline void buffer_init(struct comp_buffer *buffer, uint32_t size, uint32
static inline void buffer_reset_params(struct comp_buffer *buffer, void *data) static inline void buffer_reset_params(struct comp_buffer *buffer, void *data)
{ {
buffer = buffer_acquire(buffer); struct comp_buffer __sparse_cache *buffer_c = buffer_acquire(buffer);
buffer->hw_params_configured = false; buffer_c->hw_params_configured = false;
buffer = buffer_release(buffer); buffer_release(buffer_c);
} }
#endif /* __SOF_AUDIO_BUFFER_H__ */ #endif /* __SOF_AUDIO_BUFFER_H__ */