dma-trace: new dma_trace_initialized() function

Avoids duplication and potential divergence.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This commit is contained in:
Marc Herbert 2021-06-01 07:21:04 +00:00 committed by Liam Girdwood
parent 29b1a9fc92
commit a1c43ef855
2 changed files with 8 additions and 4 deletions

View File

@ -59,6 +59,11 @@ void dma_trace_off(void);
void dtrace_event(const char *e, uint32_t size);
void dtrace_event_atomic(const char *e, uint32_t length);
static inline bool dma_trace_initialized(const struct dma_trace_data *d)
{
return d && d->dmatb.addr;
}
static inline struct dma_trace_data *dma_trace_data_get(void)
{
return sof_get()->dmat;

View File

@ -379,9 +379,8 @@ void dma_trace_flush(void *t)
int32_t wrap_count;
int ret;
if (!trace_data || !trace_data->dmatb.addr) {
if (!dma_trace_initialized(trace_data))
return;
}
buffer = &trace_data->dmatb;
avail = buffer->avail;
@ -553,7 +552,7 @@ void dtrace_event(const char *e, uint32_t length)
struct dma_trace_buf *buffer = NULL;
unsigned long flags;
if (!trace_data || !trace_data->dmatb.addr ||
if (!dma_trace_initialized(trace_data) ||
length > DMA_TRACE_LOCAL_SIZE / 8 || length == 0) {
return;
}
@ -591,7 +590,7 @@ void dtrace_event_atomic(const char *e, uint32_t length)
{
struct dma_trace_data *trace_data = dma_trace_data_get();
if (!trace_data || !trace_data->dmatb.addr ||
if (!dma_trace_initialized(trace_data) ||
length > DMA_TRACE_LOCAL_SIZE / 8 || length == 0) {
return;
}