OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

testbench: add null pointer check for function argument 

tb_pipeline_params() function takes an argument called ipc_pipe,
which is a pointer and is derefernced in the function to access
a member of structure that pointer is pointing to.

If this pointer is NULL, this leads to Segmentation fault. A
null pointer check is added before the argument is dereferenced.

Signed-off-by: Mohana Datta Yelugoti <ymdatta.work@gmail.com>
This commit is contained in:
Mohana Datta Yelugoti 2020-07-22 12:05:29 +00:00 committed by Liam Girdwood
parent 41e62eb4ba
commit 9f1106d8a5
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/testbench/common_test.c
View File

@ -99,9 +99,16 @@ int tb_pipeline_params(struct ipc *ipc, struct sof_ipc_pipe_new *ipc_pipe,
struct sof_ipc_pcm_params params;
char message[DEBUG_MSG_LEN];
int fs_period;
int period = ipc_pipe->period;
int period;
int ret = 0;
if (!ipc_pipe) {
fprintf(stderr, "error: ipc_pipe NULL\n");
return -EINVAL;
}
period = ipc_pipe->period;
/* Compute period from sample rates */
fs_period = (int)(0.9999 + tp->fs_in * period / 1e6);
sprintf(message, "period sample count %d\n", fs_period);