From 8db2b101eea8d77b4537a3dfeeb982155e28212d Mon Sep 17 00:00:00 2001 From: Daniel Baluta Date: Thu, 30 Jan 2020 15:27:28 +0200 Subject: [PATCH] topology: imx8: Use s32le format for wm8960 codec wm8960 codec drivers the master clock and for s24le we cannot easily derive the bitclk. So, switch to s32le. SAI supports s32le format. The initial s23le was added because topology was based on sof-imx8qxp-cs42888.m4 which uses ESAI and that's limited to s24le. Signed-off-by: Daniel Baluta --- tools/topology/sof-imx8qxp-wm8960.m4 | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/topology/sof-imx8qxp-wm8960.m4 b/tools/topology/sof-imx8qxp-wm8960.m4 index 432acafa6..66c964132 100644 --- a/tools/topology/sof-imx8qxp-wm8960.m4 +++ b/tools/topology/sof-imx8qxp-wm8960.m4 @@ -31,17 +31,17 @@ dnl period, priority, core, dnl pcm_min_rate, pcm_max_rate, pipeline_rate, dnl time_domain, sched_comp) -# Low Latency playback pipeline 1 on PCM 0 using max 2 channels of s24le. +# Low Latency playback pipeline 1 on PCM 0 using max 2 channels of s32le. # Set 1000us deadline on core 0 with priority 0 PIPELINE_PCM_ADD(sof/pipe-volume-playback.m4, - 1, 0, 2, s24le, + 1, 0, 2, s32le, 1000, 0, 0, 48000, 48000, 48000) -# Low Latency capture pipeline 2 on PCM 0 using max 2 channels of s24le. +# Low Latency capture pipeline 2 on PCM 0 using max 2 channels of s32le. # Set 1000us deadline on core 0 with priority 0 PIPELINE_PCM_ADD(sof/pipe-volume-capture.m4, - 2, 0, 2, s24le, + 2, 0, 2, s32le, 1000, 0, 0, 48000, 48000, 48000) # @@ -54,17 +54,17 @@ dnl buffer, periods, format, dnl period, priority, core, time_domain) # playback DAI is SAI1 using 2 periods -# Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 +# Buffers use s32le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-playback.m4, 1, SAI, 1, sai1-wm8960-hifi, - PIPELINE_SOURCE_1, 2, s24le, + PIPELINE_SOURCE_1, 2, s32le, 1000, 0, 0, SCHEDULE_TIME_DOMAIN_DMA) # capture DAI is SAI1 using 2 periods -# Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 +# Buffers use s32le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-capture.m4, 2, SAI, 1, sai1-wm8960-hifi, - PIPELINE_SINK_2, 2, s24le, + PIPELINE_SINK_2, 2, s32le, 1000, 0, 0)