OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

qemu-check.sh: make $ROM a quoted bash array "${ROM[@]}" 

Removes shellcheck warning and could allow directory names with
whitespace in a very distant future.

Silence printf "$@" shellcheck warning in die() function.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This commit is contained in:
Marc Herbert 2020-06-26 22:20:38 -07:00 committed by Liam Girdwood
parent 77e42657c6
commit 8ceef9d460
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
scripts/qemu-check.sh
View File

@ -15,6 +15,8 @@ rm -f dump-*.txt
die() die()
{ {
>&2 printf '%s ERROR: ' "$0" >&2 printf '%s ERROR: ' "$0"
# We want die() to be usable exactly like printf
# shellcheck disable=SC2059
>&2 printf "$@" >&2 printf "$@"
exit 1 exit 1
} }
@ -145,15 +147,14 @@ do
esac esac
if $has_rom; then if $has_rom; then
ROM="-r ${SOF_BUILDS}/build_${platform}_gcc" ROM=(-r "${SOF_BUILDS}/build_${platform}_gcc/src/arch/xtensa/rom-$platform.bin")
ROM+="/src/arch/xtensa/rom-$platform.bin"
fi fi
xtensa_host_sh=$(find_qemu_xtensa) xtensa_host_sh=$(find_qemu_xtensa)
${xtensa_host_sh} "$PLATFORM" -k \ ${xtensa_host_sh} "$PLATFORM" -k \
"${SOF_BUILDS}"/build_"${platform}"_gcc/src/arch/xtensa/"$FWNAME" \ "${SOF_BUILDS}"/build_"${platform}"_gcc/src/arch/xtensa/"$FWNAME" \
$ROM \ "${ROM[@]}" \
-o 2.0 "${SOF_BUILDS}"/dump-"$platform".txt || true # timeout -o 2.0 "${SOF_BUILDS}"/dump-"$platform".txt || true # timeout
# dump log into sof.git incase running in docker # dump log into sof.git incase running in docker