OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

audio: volume: disable HIFI4 optimizations 

HIFI4 has been disabled. HIFI3 is being used for
the volume component with peakVol.

There was a problem with test
test_01_09_peakvol_quality[44100Hz_16in16bit_1ch-0].
The main problem was with frequencies: 11025,
22050, 44100, 88200, 176400 Hz.
Because frame is different for these frequencies. For f=44100Hz
frame is equal 44 or 45. Some of the samples were simply not processed.

Changes to HIFI4 are not-trivial and failed to fix the problem.
However, HIFI3 is fully compatible and works properly.
Performance is worse by 1-2,5% in CPU cycle usage
but no glitches appear and all samples are processed correctly.

Signed-off-by: Grzegorz Bernat <grzegorzx.bernat@intel.com>
This commit is contained in:
Grzegorz Bernat 2024-06-07 14:36:45 +02:00 committed by Kai Vehmanen
parent e137e9bcb8
commit 87571f337c
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/audio/volume/volume_hifi3_with_peakvol.c
View File

@ -21,7 +21,9 @@ LOG_MODULE_DECLARE(volume_hifi3, CONFIG_SOF_LOG_LEVEL);
#include "volume.h"
#if SOF_USE_HIFI(3, VOLUME)
// Hifi4 is disabled, see bug https://github.com/thesofproject/sof/issues/9213
// Hifi5 is not there yet.
#if SOF_USE_HIFI(3, VOLUME) || SOF_USE_HIFI(4, VOLUME) || SOF_USE_HIFI(5, VOLUME)
#if CONFIG_COMP_PEAK_VOL

3
src/audio/volume/volume_hifi4_with_peakvol.c
View File

@ -21,7 +21,8 @@ LOG_MODULE_DECLARE(volume_hifi4, CONFIG_SOF_LOG_LEVEL);
#include "volume.h"
#if SOF_USE_HIFI(4, VOLUME) || SOF_USE_HIFI(5, VOLUME)
// disabled and replaced by HIFI3, see issue https://github.com/thesofproject/sof/issues/9213
#if 0 // SOF_USE_HIFI(4, VOLUME) || SOF_USE_HIFI(5, VOLUME)
#if CONFIG_COMP_PEAK_VOL
#include <xtensa/tie/xt_hifi4.h>