OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

ipc4: fix pipeline reset 

During pipeline reset all components remains in previous state. This
cause issue at pipeline deletion. This patch allowed to propagate state
transition to all pipeline components.

Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
This commit is contained in:
Tomasz Leman 2022-02-10 09:47:57 +01:00 committed by Liam Girdwood
parent 4ec8d8b6f5
commit 819c023d23
1 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/ipc/ipc4/handler.c
View File

@ -153,6 +153,30 @@ error:
return err;
}
static int propagate_state_to_ppl_comp(struct ipc *ipc, uint32_t ppl_id, int cmd)
{
int ret = IPC4_INVALID_RESOURCE_ID;
struct ipc_comp_dev *icd;
struct list_item *clist;
list_for_item(clist, &ipc->comp_list) {
icd = container_of(clist, struct ipc_comp_dev, list);
if (icd->type != COMP_TYPE_COMPONENT)
continue;
if (!cpu_is_me(icd->core))
continue;
if (ipc_comp_pipe_id(icd) == ppl_id) {
ret = comp_set_state(icd->cd, cmd);
if (ret != 0)
return IPC4_INVALID_REQUEST;
}
}
return ret;
}
/* Ipc4 pipeline message <------> ipc3 pipeline message
* RUNNING <-------> TRIGGER START
* INIT + PAUSED <-------> PIPELINE COMPLETE
@ -262,9 +286,13 @@ static int set_pipeline_state(uint32_t id, uint32_t cmd, bool *delayed)
}
}
ret = propagate_state_to_ppl_comp(ipc, id, COMP_TRIGGER_RESET);
if (ret != 0)
return ret;
/* resource is not released by triggering reset which is used by current FW */
ret = pipeline_reset(host->cd->pipeline, host->cd);
if (ret < 0)
if (ret != 0)
ret = IPC4_INVALID_REQUEST;
return ret;