OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

host: do not free the list header in host_reset 

The CONFIG_DMA_GW only enable with hda_dma, as the create_local_elems is
refined to create elem at every start. Did not need to keep the first
elem.

Use list_for_item_safe to delete all item in list. The old way will
delete and free the list header with belongs to the host_data. Free
the list header will directly free host_data and make the second run
fail if the memory is alloced again.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
This commit is contained in:
Pan Xiuli 2018-09-20 17:50:22 +08:00
parent d7404c587e
commit 7eae0a4264
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/audio/host.c
View File

@ -670,21 +670,14 @@ static int host_reset(struct comp_dev *dev)
dma_stop(hd->dma, hd->chan);
dma_channel_put(hd->dma, hd->chan);
e = list_first_item(&hd->config.elem_list,
struct dma_sg_elem, list);
/*
* here free dma_sg_elem those allocated in create_local_elems(),
* we should keep header and the first local elem after reset (but only
* for dw-dma since hda-dma allocates the full list again)
* we should only keep header since hda-dma allocates the full
* list again
*/
list_for_item_safe(elist, tlist, &e->list) {
list_for_item_safe(elist, tlist, &hd->config.elem_list) {
e = container_of(elist, struct dma_sg_elem, list);
#if !defined CONFIG_DMA_GW
/* should not free the header, finished */
if (elist == &hd->config.elem_list)
break;
#endif
list_item_del(&e->list);
list_item_del(elist);
rfree(e);
}
#endif