OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

xtensa-build-zephyr.py: do not modify submodules after building! 

The older shell script had a deprecated convenience hack to clone
submodules before building rimage but _only if submodules were missing_!

While trying to preserve that, the new script changed that to an
unconditional git submodule update that can be destructive when
submodules are already present.

Generally speaking, using git and building must always be two very
distinct activities. No one wants the source code to change quietly from
one build to the next.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This commit is contained in:
Marc Herbert 2022-03-10 18:40:33 +00:00 committed by Liam Girdwood
parent 7a847a5bd8
commit 78667c028d
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/xtensa-build-zephyr.py
View File

@ -367,8 +367,6 @@ def build_platforms():
# Extract metadata # Extract metadata
execute_command([str(smex_executable), "-l", str(fw_ldc_file), str(input_elf_file)], execute_command([str(smex_executable), "-l", str(fw_ldc_file), str(input_elf_file)],
check=True) check=True)
# Update SOF submodules
git_submodules_update()
# CMake - configure rimage module # CMake - configure rimage module
rimage_dir_name="build-rimage" rimage_dir_name="build-rimage"
sof_mirror_dir = pathlib.Path("modules", "audio", "sof") sof_mirror_dir = pathlib.Path("modules", "audio", "sof")