OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

ipc4: fix trace format mismatches 

Two tr_err() calls in src/ipc/ipc4/handler.c have mismatching formats
and arguments. When built with Zephyr, tr_err() translates to
printk() which then checks arguments. This allows an easy detection
of such errors.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
This commit is contained in:
Guennadi Liakhovetski 2022-01-24 13:45:30 +01:00 committed by Liam Girdwood
parent 2097ba2d27
commit 6ab8c11136
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/ipc/ipc4/handler.c
View File

@ -210,8 +210,7 @@ static int set_pipeline_state(uint32_t id, uint32_t cmd, bool *delayed)
host = ipc_get_comp_by_id(ipc, host_id);
if (!host) {
tr_err(&ipc_tr, "ipc: comp host not found",
pcm_dev->pipeline->source_comp->ipc_config.id);
tr_err(&ipc_tr, "ipc: comp host with ID %d not found", host_id);
return IPC4_INVALID_RESOURCE_ID;
}
@ -631,7 +630,7 @@ static int ipc4_set_large_config_module_instance(union ipc4_message_header *ipc4
int ret;
memcpy_s(&config, sizeof(config), ipc4, sizeof(config));
tr_dbg(&ipc_tr, "ipc4_set_large_config_module_instance %x : %x with %x : %x",
tr_dbg(&ipc_tr, "ipc4_set_large_config_module_instance %x : %x",
(uint32_t)config.header.r.module_id, (uint32_t)config.header.r.instance_id);
drv = ipc4_get_comp_drv(config.header.r.module_id);
@ -654,7 +653,7 @@ static int ipc4_set_large_config_module_instance(union ipc4_message_header *ipc4
config.data.r.final_block, config.data.r.data_off_size,
(char *)MAILBOX_HOSTBOX_BASE);
if (ret < 0) {
tr_err(&ipc_tr, "failed to set large_config_module_instance %x : %x with %x : %x",
tr_err(&ipc_tr, "failed to set large_config_module_instance %x : %x",
(uint32_t)config.header.r.module_id, (uint32_t)config.header.r.instance_id);
ret = IPC4_INVALID_RESOURCE_ID;
}