OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Audio: ASRC: Track skew min/max values and trace them in asrc_reset() 

This patch adds useful trace to help solve possible issues with slave
DAI rate stability. If there are quality issues with ASRC, it is
useful to check the reported values. Skew values are Q2.30 fractional
integers.

E.g. at skew of 1073518174 the measured DAI sample rate is
48000*2^30/1073518174 = 48010 Hz when nominal rate is 48 kHz.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This commit is contained in:
Seppo Ingalsuo 2020-06-30 14:38:29 +03:00 committed by Liam Girdwood
parent f63adb42d9
commit 656b36967a
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/audio/asrc/asrc.c
View File

@ -66,6 +66,8 @@ struct comp_data {
int32_t ts_prev;
int32_t sample_prev;
int32_t skew; /* Rate factor in Q2.30 */
int32_t skew_min;
int32_t skew_max;
int ts_count;
int asrc_size; /* ASRC object size */
int buf_size; /* Samples buffer size */
@ -676,6 +678,9 @@ static int asrc_prepare(struct comp_dev *dev)
if (!cd->skew)
cd->skew = Q_CONVERT_FLOAT(1.0, 30);
cd->skew_min = cd->skew;
cd->skew_max = cd->skew;
comp_info(dev, "asrc_prepare(), skew = %d", cd->skew);
ret = asrc_update_drift(dev, cd->asrc_obj, cd->skew);
if (ret) {
@ -776,6 +781,12 @@ static int asrc_control_loop(struct comp_dev *dev, struct comp_data *cd)
tmp = ((int64_t)COEF_C1) * skew + ((int64_t)COEF_C2) * cd->skew;
cd->skew = sat_int32(Q_SHIFT_RND(tmp, 60, 30));
asrc_update_drift(dev, cd->asrc_obj, cd->skew);
/* Track skew variation, it helps to analyze possible problems
* with slave DAI frame clock stability.
*/
cd->skew_min = MIN(cd->skew, cd->skew_min);
cd->skew_max = MAX(cd->skew, cd->skew_max);
comp_cl_dbg(&comp_asrc, "skew %d %d %d %d", delta_sample, delta_ts,
skew, cd->skew);
return 0;
@ -870,6 +881,9 @@ static int asrc_reset(struct comp_dev *dev)
struct comp_data *cd = comp_get_drvdata(dev);
comp_info(dev, "asrc_reset()");
comp_info(dev, "asrc_reset(), skew_min=%d, skew_max=%d", cd->skew_min,
cd->skew_max);
/* If any resources feasible to stop */
if (cd->track_drift)