From 61c91be9fd69e33f29017d1d6d2d481402ba2040 Mon Sep 17 00:00:00 2001 From: Guennadi Liakhovetski Date: Fri, 30 Apr 2021 16:23:53 +0200 Subject: [PATCH] scheduler: remove .scheduler_run The .scheduler_run() operation is never used, remove it. Signed-off-by: Guennadi Liakhovetski --- src/include/sof/schedule/schedule.h | 12 ++---------- src/platform/library/schedule/edf_schedule.c | 6 ------ src/schedule/edf_schedule.c | 1 - src/schedule/ll_schedule.c | 1 - 4 files changed, 2 insertions(+), 18 deletions(-) diff --git a/src/include/sof/schedule/schedule.h b/src/include/sof/schedule/schedule.h index e44577a70..17098cf61 100644 --- a/src/include/sof/schedule/schedule.h +++ b/src/include/sof/schedule/schedule.h @@ -38,8 +38,8 @@ enum { * Scheduler operations. * * Almost all schedule operations must return 0 for success and negative values - * for errors. Only scheduler_free and scheduler_run operations are allowed - * to not return any status. + * for errors. Only the scheduler_free operation is allowed to not return any + * status. */ struct scheduler_ops { /** @@ -116,14 +116,6 @@ struct scheduler_ops { * This operation is optional. */ void (*scheduler_free)(void *data); - - /** - * Starts scheduler (not all schedulers require to be manually started). - * @param data Private data of selected scheduler. - * - * This operation is optional. - */ - void (*scheduler_run)(void *data); }; /** \brief Holds information about scheduler. */ diff --git a/src/platform/library/schedule/edf_schedule.c b/src/platform/library/schedule/edf_schedule.c index 19786467d..07e0b1d3a 100644 --- a/src/platform/library/schedule/edf_schedule.c +++ b/src/platform/library/schedule/edf_schedule.c @@ -90,11 +90,6 @@ static void edf_scheduler_free(void *data) free(data); } -/* The following definitions are to satisfy libsof linker errors */ -static void schedule_edf(void *data) -{ -} - static int schedule_edf_task_cancel(void *data, struct task *task) { if (task->state == SOF_TASK_STATE_QUEUED) { @@ -126,5 +121,4 @@ static struct scheduler_ops schedule_edf_ops = { .schedule_task_cancel = schedule_edf_task_cancel, .schedule_task_free = schedule_edf_task_free, .scheduler_free = edf_scheduler_free, - .scheduler_run = schedule_edf }; diff --git a/src/schedule/edf_schedule.c b/src/schedule/edf_schedule.c index 7a29ff35c..be1f85cdc 100644 --- a/src/schedule/edf_schedule.c +++ b/src/schedule/edf_schedule.c @@ -315,5 +315,4 @@ static const struct scheduler_ops schedule_edf_ops = { .schedule_task_cancel = schedule_edf_task_cancel, .schedule_task_free = schedule_edf_task_free, .scheduler_free = scheduler_free_edf, - .scheduler_run = schedule_edf }; diff --git a/src/schedule/ll_schedule.c b/src/schedule/ll_schedule.c index 310675458..c87b5cdb5 100644 --- a/src/schedule/ll_schedule.c +++ b/src/schedule/ll_schedule.c @@ -659,5 +659,4 @@ static const struct scheduler_ops schedule_ll_ops = { .scheduler_free = scheduler_free_ll, .schedule_task_running = NULL, .schedule_task_complete = NULL, - .scheduler_run = NULL };