OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

sof-ctl: Fix -Wformat,-Wsometimes-uninitialized 

* Use %z specifier for size types to avoid format
  specifier warnings on arm32
* in ctl_dump(), size_t n may be used uninitialized
  if ctl_data->out_fd > 0 and !ctl_data->binary.

Signed-off-by: Li-Yu Yu <aaronyu@google.com>
This commit is contained in:
Li-Yu Yu 2022-04-28 17:18:56 +08:00 committed by Liam Girdwood
parent 0d5e731b19
commit 5cfc37040b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/ctl/ctl.c
View File

@ -202,7 +202,7 @@ static void hex_data_dump(struct ctl_data *ctl_data)
/* Print out in 16bit hex format */ /* Print out in 16bit hex format */
for (i = 0; i < n; i++) { for (i = 0; i < n; i++) {
if (!(i % 8)) if (!(i % 8))
fprintf(stdout, "%08lx ", fprintf(stdout, "%08zx ",
i * sizeof(uint16_t)); i * sizeof(uint16_t));
fprintf(stdout, "%04x ", config[i]); fprintf(stdout, "%04x ", config[i]);
if ((i % 8) == 7) if ((i % 8) == 7)
@ -410,7 +410,7 @@ static void ctl_dump(struct ctl_data *ctl_data)
{ {
FILE *fh; FILE *fh;
int offset = 0; int offset = 0;
size_t n;/* in bytes */ size_t n = 0;/* in bytes */
if (ctl_data->out_fd > 0) { if (ctl_data->out_fd > 0) {
if (ctl_data->binary) { if (ctl_data->binary) {
@ -441,7 +441,7 @@ static void ctl_dump(struct ctl_data *ctl_data)
csv_data_dump(ctl_data, fh); csv_data_dump(ctl_data, fh);
} }
fprintf(stdout, "%ld bytes written to file.\n", n); fprintf(stdout, "%zd bytes written to file.\n", n);
fclose(fh); fclose(fh);
} else { } else {
/* dump to stdout */ /* dump to stdout */