OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

imx: edma: Remove CSR_START register set on edma_start 

The aim of this patch is to fix the following issue:
after some pause-release operations the sound would play
with higher volume in one earpiece compared to the other one.
This seemed to happen only during a certain part of some song
(the beginning).

By removing the unnecessary set of CSR_START register in
edma_start the problem seemed to have disappeared. Setting
aforementioned register in edma_start is not necessary
because we don't need to explicitly start a channel in the
software. The hardware will take care of it.

Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
This commit is contained in:
Laurentiu Mihalcea 2022-08-19 14:14:58 +03:00 committed by Liam Girdwood
parent 3054174108
commit 52979f35cc
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/drivers/imx/edma.c
View File

@ -151,9 +151,6 @@ static int edma_start(struct dma_chan_data *channel)
return -EINVAL;
channel->status = COMP_STATE_ACTIVE;
/* Do the HW start of the DMA */
dma_chan_reg_update_bits(channel, EDMA_TCD_CSR,
EDMA_TCD_CSR_START, EDMA_TCD_CSR_START);
/* Allow the HW to automatically trigger further transfers */
dma_chan_reg_update_bits(channel, EDMA_CH_CSR,
EDMA_CH_CSR_ERQ_EARQ, EDMA_CH_CSR_ERQ_EARQ);