OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

volume: fix cache invalidation in volume_set_config() 

With IPC4 volume_set_config() is called from
module_set_large_config() with the host mailbox used as a
configuration source. Data there is written by the host, therefore
any DSP cache contents for that area is invalid. volume_set_config()
does invalidate local cache for that area but it's doing it too late
- after calling module_set_configuration() which already reads the
data. This leads to sporadic wrong configuration readings. Move cache
invalidation before module_set_configuration() to fix that.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
This commit is contained in:
Guennadi Liakhovetski 2022-09-08 14:01:48 +02:00 committed by Liam Girdwood
parent 365658ca5e
commit 4e0f0dec1f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/audio/module_adapter/module/volume/volume.c
View File

@ -925,6 +925,8 @@ static int volume_set_config(struct processing_module *mod, uint32_t config_id,
comp_dbg(dev, "volume_set_config()");
dcache_invalidate_region((__sparse_force void __sparse_cache *)fragment, fragment_size);
ret = module_set_configuration(mod, config_id, pos, data_offset_size, fragment,
fragment_size, response, response_size);
if (ret < 0)
@ -936,8 +938,6 @@ static int volume_set_config(struct processing_module *mod, uint32_t config_id,
return 0;
cdata = (struct ipc4_peak_volume_config *)ASSUME_ALIGNED(fragment, 8);
// BUG: data is the IPC data from sof->ipc->comp_data which is uncached
dcache_invalidate_region((__sparse_force void __sparse_cache *)cdata, sizeof(*cdata));
cdata->target_volume = convert_volume_ipc4_to_ipc3(dev, cdata->target_volume);
init_ramp(cd, cdata->curve_duration, cdata->target_volume);