OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

xtensa: cmake: clang scan build support 

Add support for compiling FW with settings acceptable for clang,
in order to let it perform static analysis on the code.

Clang works mostly on ASTs made out of C code, so there is
no need to build complete signed binary for it.

Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
This commit is contained in:
Janusz Jankowski 2020-02-27 14:39:52 +01:00
parent 6f7bf63417
commit 4da2c9659c
2 changed files with 59 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
scripts/cmake/xtensa-toolchain.cmake
View File

@ -1,4 +1,33 @@
# SPDX-License-Identifier: BSD-3-Clause
if(TOOLCHAIN)
set(CROSS_COMPILE "${TOOLCHAIN}-")
else()
message(FATAL_ERROR
" Please specify toolchain to use.\n"
" Examples:\n"
" 1) cmake -DTOOLCHAIN=xt ...\n"
" 2) cmake -DTOOLCHAIN=xtensa-apl-elf ...\n"
)
endif()
if(BUILD_CLANG_SCAN)
# scan-build has to set its own compiler,
# so we need to unset current one
message(STATUS "Reset C Compiler for scan-build")
set(CMAKE_C_COMPILER)
# scan-build proxies only compiler, other tools are used directly
find_program(CMAKE_AR NAMES "${CROSS_COMPILE}ar" PATHS ENV PATH NO_DEFAULT_PATH)
find_program(CMAKE_RANLIB NAMES "${CROSS_COMPILE}ranlib" PATHS ENV PATH NO_DEFAULT_PATH)
set(XCC_TOOLS_VERSION "CLANG-SCAN-BUILD")
if(TOOLCHAIN STREQUAL "xt")
set(XCC 1)
endif()
return()
endif()
message(STATUS "Preparing Xtensa toolchain")
@ -17,17 +46,6 @@ set(CMAKE_C_COMPILER_ID GNU)
# try to just compile lib instead of executable
set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)
if(TOOLCHAIN)
set(CROSS_COMPILE "${TOOLCHAIN}-")
else()
message(FATAL_ERROR
" Please specify toolchain to use.\n"
" Examples:\n"
" 1) cmake -DTOOLCHAIN=xt ...\n"
" 2) cmake -DTOOLCHAIN=xtensa-apl-elf ...\n"
)
endif()
# xt toolchain only partially follows gcc convention
if(TOOLCHAIN STREQUAL "xt")
set(XCC 1)

32
src/arch/xtensa/CMakeLists.txt
View File

@ -67,11 +67,33 @@ endif()
get_optimization_flag(optimization_flag)
if(BUILD_CLANG_SCAN)
# pretend to be xtensa compiler to go trough the same paths for AST
target_compile_definitions(sof_options INTERFACE -D__XTENSA__=1)
if(XCC)
# clang has to compile objects in order to analyze sources,
# so it needs xcc's headers
find_program(XCC_PATH NAMES "xt-xcc" PATHS ENV PATH NO_DEFAULT_PATH)
get_filename_component(XCC_DIR ${XCC_PATH} DIRECTORY)
target_include_directories(sof_options INTERFACE ${XCC_DIR}/../xtensa-elf/include)
endif()
# Clang by default compiles for host architecture,
# but xtensa is always 32 bit, what may cause mismatch in definitions,
# that depend on bitness, so force compilation for 32 bit.
set(XTENSA_C_ASM_FLAGS -m32)
set(XTENSA_C_FLAGS)
else()
set(XTENSA_C_ASM_FLAGS -mlongcalls)
set(XTENSA_C_FLAGS -mtext-section-literals)
endif()
# linker flags
target_link_libraries(sof_options INTERFACE ${stdlib_flag} -Wl,--no-check-sections -ucall_user_start -Wl,-static)
# C & ASM flags
target_compile_options(sof_options INTERFACE ${stdlib_flag} -fno-inline-functions -mlongcalls)
target_compile_options(sof_options INTERFACE ${stdlib_flag} -fno-inline-functions ${XTENSA_C_ASM_FLAGS})
# C flags
# TODO: Generator expressions are supported only with Make and Ninja,
@ -83,7 +105,7 @@ target_compile_options(sof_options INTERFACE ${stdlib_flag} -fno-inline-function
# better to have set of default flags and change it only for special cases
# 3) custom function that is used instead of target_sources and sets flags
# for each added source based on file extension
target_compile_options(sof_options INTERFACE $<$<COMPILE_LANGUAGE:C>: -${optimization_flag} -g -Wall -Werror -Wl,-EL -Wmissing-prototypes -Wpointer-arith -mtext-section-literals>)
target_compile_options(sof_options INTERFACE $<$<COMPILE_LANGUAGE:C>: -${optimization_flag} -g -Wall -Werror -Wl,-EL -Wmissing-prototypes -Wpointer-arith ${XTENSA_C_FLAGS}>)
if(BUILD_UNIT_TESTS)
# rest of this file is not needed for unit tests
@ -281,6 +303,12 @@ if(CONFIG_BUILD_VM_ROM)
add_dependencies(bin_extras rom_dump)
endif()
if(BUILD_CLANG_SCAN)
# steps below don't compile parts of fw,
# so they are not needed for scan-build
return()
endif()
add_custom_target(
sof_dump
COMMAND ${CMAKE_OBJDUMP} -S sof-${fw_name} > sof-${fw_name}.lst