OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

ipc4: set_dx: ignoring logger status notifications 

Before HOST can request FW to enter D3 state, has to stop all pipelines.
If it's done properly all possible source of IPC messages from FW to
HOST are disabled.

The only exception from this is logger. If logs are enabled FW will
continue to produce new traces and eventually trigger threshold
notification.

This notification is not critical so we can skip it during D3 entry. The
message will remain in the internal list and will be sent when the DSP
wakes up.

Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
This commit is contained in:
Tomasz Leman 2023-08-10 12:07:34 +02:00 committed by Kai Vehmanen
parent fb6c3b7e9d
commit 49199a6aed
1 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/ipc/ipc-zephyr.c
View File

@ -35,6 +35,8 @@
#include <rtos/task.h>
#include <rtos/spinlock.h>
#include <ipc/header.h>
#include <sof/ipc/msg.h>
#include <ipc4/notification.h>
#include <stdbool.h>
#include <stddef.h>
@ -112,9 +114,28 @@ static int ipc_device_suspend_handler(const struct device *dev, void *arg)
}
if (!list_is_empty(&ipc->msg_list)) {
struct list_item *slist;
struct ipc_msg *msg;
/* The only possible message that can be added during power transition procedure is
* SOF_IPC4_NOTIFY_LOG_BUFFER_STATUS.
*/
const uint32_t exp_hdr = SOF_IPC4_NOTIF_HEADER(SOF_IPC4_NOTIFY_LOG_BUFFER_STATUS);
bool only_buff_status = true;
list_for_item(slist, &ipc->msg_list) {
msg = container_of(slist, struct ipc_msg, list);
if (msg->header != exp_hdr)
only_buff_status = false;
}
if (only_buff_status) {
tr_warn(&ipc_tr, "continuing D3 procedure with the msg in the queue");
} else {
tr_err(&ipc_tr, "there are queued IPC messages to be sent");
ret = -EINPROGRESS;
}
}
if (ret != 0)
ipc_send_failed_power_transition_response();