OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Tools: Testbench: Add system agent initialization 

This patch fixes a segfault with null sof->sa pointer in
pipeline_schedule_copy() function. The bug has not been observed
with test topologies for processing pipelines but with other
topologies with fuzzer varied parameters.

The sa_init() is added to tb_pipeline_setup(). The scheduler_init_edf()
is a dependency. The two dummy functions platform_timer_get() and
clock_ms_to_ticks() are also added as dependency. The CMakelist for
library is edited to include agent.c build for testbench.

Fixes #3247

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This commit is contained in:
Seppo Ingalsuo 2020-08-26 18:45:50 +03:00 committed by Liam Girdwood
parent d697516c32
commit 40fd801c29
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/lib/CMakeLists.txt
View File

@ -3,7 +3,8 @@
if(CONFIG_LIBRARY) if(CONFIG_LIBRARY)
add_local_sources(sof add_local_sources(sof
lib.c lib.c
notifier.c) notifier.c
agent.c)
return() return()
endif() endif()

13
tools/testbench/common_test.c
View File

@ -14,6 +14,7 @@
#include <sof/lib/alloc.h> #include <sof/lib/alloc.h>
#include <sof/lib/notifier.h> #include <sof/lib/notifier.h>
#include <sof/drivers/ipc.h> #include <sof/drivers/ipc.h>
#include <sof/lib/agent.h>
#include <sof/lib/dai.h> #include <sof/lib/dai.h>
#include <sof/lib/dma.h> #include <sof/lib/dma.h>
#include <sof/schedule/edf_schedule.h> #include <sof/schedule/edf_schedule.h>
@ -33,6 +34,8 @@ int tb_pipeline_setup(struct sof *sof)
/* other necessary initializations, todo: follow better SOF init */ /* other necessary initializations, todo: follow better SOF init */
pipeline_posn_init(sof); pipeline_posn_init(sof);
init_system_notify(sof); init_system_notify(sof);
scheduler_init_edf();
sa_init(sof, CONFIG_SYSTICK_PERIOD);
/* init IPC */ /* init IPC */
if (ipc_init(sof) < 0) { if (ipc_init(sof) < 0) {
@ -230,3 +233,13 @@ void dma_sg_free(struct dma_sg_elem_array *elem_array)
void pipeline_xrun(struct pipeline *p, struct comp_dev *dev, int32_t bytes) void pipeline_xrun(struct pipeline *p, struct comp_dev *dev, int32_t bytes)
{ {
} }
uint64_t platform_timer_get(struct timer *timer)
{
return 0;
}
uint64_t clock_ms_to_ticks(int clock, uint64_t ms)
{
return 0;
}