From 2e6cafa02fca352c9f4a085d3c44925e61a19253 Mon Sep 17 00:00:00 2001
From: Marc Herbert <marc.herbert@intel.com>
Date: Mon, 22 Mar 2021 01:18:36 +0000
Subject: [PATCH] logger: use strerror()

Useful error messages when forgetting to use "sudo" or to change
permissions in udev.

Some places were printing the errno decimal. Others no specific error
at all.

Sample outputs:

error: Unable to open version file /sys/kernel/debug/sof/fw_version: \
                                                       Permission denied

error: Unable to open version file /sys/kernel/debug/sof/fw_version: \
                                               No such file or directory

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
---
 tools/logger/logger.c | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/tools/logger/logger.c b/tools/logger/logger.c
index 9d2826910..850df3c32 100644
--- a/tools/logger/logger.c
+++ b/tools/logger/logger.c
@@ -87,16 +87,16 @@ static int snapshot(const char *name)
 		/* open debugfs for reading */
 		in_fd = fopen(pinname, "rb");
 		if (!in_fd) {
-			fprintf(stderr, "error: unable to open %s for reading %d\n",
-				pinname, errno);
+			fprintf(stderr, "error: unable to open %s for reading: %s\n",
+				pinname, strerror(errno));
 			continue;
 		}
 
 		/* open outfile for writing */
 		out_fd = fopen(poutname, "wb");
 		if (!out_fd) {
-			fprintf(stderr, "error: unable to open %s for writing %d\n",
-				poutname, errno);
+			fprintf(stderr, "error: unable to open %s for writing: %s\n",
+				poutname, strerror(errno));
 			fclose(in_fd);
 			continue;
 		}
@@ -277,18 +277,19 @@ int main(int argc, char *argv[])
 
 	config.ldc_fd = fopen(config.ldc_file, "rb");
 	if (!config.ldc_fd) {
-		fprintf(stderr, "error: Unable to open ldc file %s\n",
-			config.ldc_file);
 		ret = errno;
+		fprintf(stderr, "error: Unable to open ldc file %s: %s\n",
+			config.ldc_file, strerror(ret));
 		goto out;
 	}
 
 	if (config.version_fw) {
 		config.version_fd = fopen(config.version_file, "rb");
 		if (!config.version_fd) {
-			fprintf(stderr, "error: Unable to open version file %s\n",
-				config.version_file);
 			ret = errno;
+			fprintf(stderr,
+				"error: Unable to open version file %s: %s\n",
+				config.version_file, strerror(ret));
 			goto out;
 		}
 	}
@@ -296,9 +297,9 @@ int main(int argc, char *argv[])
 	if (config.out_file) {
 		config.out_fd = fopen(config.out_file, "w");
 		if (!config.out_fd) {
-			fprintf(stderr, "error: Unable to open out file %s\n",
-				config.out_file);
 			ret = errno;
+			fprintf(stderr, "error: Unable to open out file %s: %s\n",
+				config.out_file, strerror(ret));
 			goto out;
 		}
 	} else {
@@ -324,9 +325,10 @@ int main(int argc, char *argv[])
 	} else if (config.in_file) {
 		config.in_fd = fopen(config.in_file, "rb");
 		if (!config.in_fd) {
-			fprintf(stderr, "error: Unable to open in file %s\n",
-				config.in_file);
 			ret = errno;
+			fprintf(stderr,
+				"error: Unable to open in file %s: %s\n",
+				config.in_file, strerror(ret));
 			goto out;
 		}
 	}