OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

DMIC: Add robustness against erroneous configuration parameters 

This patch ensures that modes matching request returns immediately if
the results length would exceed the allocated length. The caller function
will issue an error in such case.

Also the possibility of using array pdm[] in the IPM helper function
as uninitialized is avoided by initializing it with zeros.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This commit is contained in:
Seppo Ingalsuo 2018-05-22 20:07:08 +03:00 committed by Liam Girdwood
parent e5dab2ada6
commit 2979baa3e5
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/drivers/dmic.c
View File

@ -334,6 +334,11 @@ static void match_modes(struct matched_modes *c, struct decim_modes *a,
return;
}
/* Ensure that num_of_modes is sane. */
if (a->num_of_modes > DMIC_MAX_MODES ||
b->num_of_modes > DMIC_MAX_MODES)
return;
/* Check for request only for FIFO A or B. In such case pass list for
* A or B as such.
*/
@ -633,7 +638,7 @@ static int select_mode(struct dmic_configuration *cfg,
static inline void ipm_helper(int *ipm, int stereo[], int swap[],
struct sof_ipc_dai_dmic_params *dmic)
{
int pdm[DMIC_HW_CONTROLLERS];
int pdm[DMIC_HW_CONTROLLERS] = {0};
int cnt;
int i;