OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Audio: Module adapter: Fix return value when no prepare operation 

The build of testbench for MTL platform simulation causes this build
fail (rebuilt-testbench -p mtl):

src/audio/module_adapter/module/generic.c:213:6:
error: variable 'ret' is used uninitialized whenever 'if'
condition is false [-Werror,-Wsometimes-uninitialized]
        if (md->ops->prepare) {
            ^~~~~~~~~~~~~~~~

src/audio/module_adapter/module/generic.c:236:9:
note: uninitialized use occurs here
        return ret;
               ^~~

Since it's a possibility to have a module without prepare()
operation, the initialize to zero is added to avoid the
return of undefined value.

Reported-by: Marc Herbert <marc.herbert@intel.com>
Signed-off-by: shastry <malladi.sastry@intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This commit is contained in:
Seppo Ingalsuo 2023-12-11 12:17:06 +02:00 committed by Liam Girdwood
parent fd61ed6151
commit 240cc9786a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/audio/module_adapter/module/generic.c
View File

@ -198,7 +198,7 @@ int module_prepare(struct processing_module *mod,
struct sof_source **sources, int num_of_sources, struct sof_source **sources, int num_of_sources,
struct sof_sink **sinks, int num_of_sinks) struct sof_sink **sinks, int num_of_sinks)
{ {
int ret; int ret = 0;
struct module_data *md = &mod->priv; struct module_data *md = &mod->priv;
struct comp_dev *dev = mod->dev; struct comp_dev *dev = mod->dev;