OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

tools: testbench:add null pointer variable check before accessing it 

When the realloc() function fails, a NULL pointer is returned. But,
if the size argument is zero, then also NULL is returned. So, to
differentiate that, we also check if size is non zero. Only if
pointer is NULL and size is non-zero, we come to the conclusion that
realloc() failed and the allocated memory till now is freed and
appropriate error is returned.

If realloc is called on a pointer and fails, the memory pointed by
the pointer isn't freed. When realloc() fails, even this memory
is freed.

Signed-off-by: Mohana Datta Yelugoti <ymdatta.work@gmail.com>
This commit is contained in:
Mohana Datta Yelugoti 2020-07-30 17:26:49 +00:00 committed by Liam Girdwood
parent 3b3d0ae2eb
commit 108912bba8
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/testbench/topology.c
View File

@ -682,7 +682,7 @@ int parse_topology(struct sof *sof, struct shared_lib_table *library_table,
/* initialize output file index */
output_file_index = 0;
struct comp_info *temp_comp_list = NULL;
struct comp_info *temp_comp_list = NULL, *comp_list_realloc = NULL;
char message[DEBUG_MSG_LEN];
int next_comp_id = 0;
int num_comps = 0;
@ -746,9 +746,18 @@ int parse_topology(struct sof *sof, struct shared_lib_table *library_table,
num_comps += hdr->count;
size = sizeof(struct comp_info) * num_comps;
temp_comp_list = (struct comp_info *)
comp_list_realloc = (struct comp_info *)
realloc(temp_comp_list, size);
if (!comp_list_realloc && size) {
free(temp_comp_list);
free(hdr);
fclose(file);
fprintf(stderr, "error: mem realloc\n");
return -errno;
}
temp_comp_list = comp_list_realloc;
for (i = (num_comps - hdr->count); i < num_comps; i++)
temp_comp_list[i].name = NULL;