OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

handler: rework ipc_cmd to return only once and log last request 

This patch edit ipc_cmd (main ipc dispatcher) to return only at
the end of the function. This simplifies debugging a lot.
Along with that change additional log has been added at the
end of the function to show what was the the last request
and its return value.

Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
This commit is contained in:
Marcin Rajwa 2019-07-17 17:27:23 +02:00 committed by Tomasz Lauda
parent db000b3276
commit 0652cb186d
1 changed files with 30 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/ipc/handler.c
View File

@ -1070,42 +1070,60 @@ int ipc_cmd(void)
{
struct sof_ipc_cmd_hdr *hdr;
uint32_t type;
int ret;
hdr = mailbox_validate();
if (hdr == NULL) {
trace_ipc_error("ipc: invalid IPC header.");
return -EINVAL;
ret = -EINVAL;
goto out;
}
type = iGS(hdr->cmd);
switch (type) {
case SOF_IPC_GLB_REPLY:
return 0;
ret = 0;
break;
case SOF_IPC_GLB_COMPOUND:
return -EINVAL; /* TODO */
ret = -EINVAL; /* TODO */
break;
case SOF_IPC_GLB_TPLG_MSG:
return ipc_glb_tplg_message(hdr->cmd);
ret = ipc_glb_tplg_message(hdr->cmd);
break;
case SOF_IPC_GLB_PM_MSG:
return ipc_glb_pm_message(hdr->cmd);
ret = ipc_glb_pm_message(hdr->cmd);
break;
case SOF_IPC_GLB_COMP_MSG:
return ipc_glb_comp_message(hdr->cmd);
ret = ipc_glb_comp_message(hdr->cmd);
break;
case SOF_IPC_GLB_STREAM_MSG:
return ipc_glb_stream_message(hdr->cmd);
ret = ipc_glb_stream_message(hdr->cmd);
break;
case SOF_IPC_GLB_DAI_MSG:
return ipc_glb_dai_message(hdr->cmd);
ret = ipc_glb_dai_message(hdr->cmd);
break;
case SOF_IPC_GLB_TRACE_MSG:
return ipc_glb_debug_message(hdr->cmd);
ret = ipc_glb_debug_message(hdr->cmd);
break;
case SOF_IPC_GLB_GDB_DEBUG:
return ipc_glb_gdb_debug(hdr->cmd);
ret = ipc_glb_gdb_debug(hdr->cmd);
break;
#ifdef CONFIG_DEBUG
case SOF_IPC_GLB_TEST:
return ipc_glb_test_message(hdr->cmd);
ret = ipc_glb_test_message(hdr->cmd);
break;
#endif
default:
trace_ipc_error("ipc: unknown command type %u", type);
return -EINVAL;
ret = -EINVAL;
break;
}
out:
tracev_ipc("ipc: last request %d returned %d", type, ret);
return ret;
}
/* locks held by caller */