From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: "he, bo" Date: Sat, 29 Sep 2018 14:18:12 +0800 Subject: [PATCH] fix the invalid double free in tdf8532 i2c read error tdf8532_single_read() is defined as return uint8_t, the error ret is defined as int, when it run into the error case, the tdf8532_single_read() won't return the error, it will cause the double free. Change-Id: I6be1438472f5f2c553e80703f761bd28d0e16d3e Tracked-On: Signed-off-by: he, bo Reviewed-on: Reviewed-by: Rojewski, Cezary Tested-by: Rojewski, Cezary --- sound/soc/codecs/tdf8532.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/tdf8532.c b/sound/soc/codecs/tdf8532.c index f306b597b42d..02e63f95512b 100644 --- a/sound/soc/codecs/tdf8532.c +++ b/sound/soc/codecs/tdf8532.c @@ -83,7 +83,7 @@ static int __tdf8532_single_write(struct tdf8532_priv *dev_data, } -static uint8_t tdf8532_read_wait_ack(struct tdf8532_priv *dev_data, +static int tdf8532_read_wait_ack(struct tdf8532_priv *dev_data, unsigned long timeout) { uint8_t ack_repl[HEADER_SIZE] = {0, 0, 0}; -- https://clearlinux.org