From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Senthilnathan Veppur Date: Wed, 23 Mar 2016 16:46:08 +0530 Subject: [PATCH] ASoC: Intel: Skylake: Add check for buffer overflow Return error if source buffer would overflow in strncpy. Change-Id: I8637aa3fed40dd5f042cb041cc5a447506bc15d2 Signed-off-by: Senthilnathan Veppur Reviewed-on: Reviewed-by: Babu, Ramesh Tested-by: Babu, Ramesh Reviewed-on: Reviewed-by: Kale, Sanyog R Reviewed-by: Avati, Santosh Kumar Tested-by: Avati, Santosh Kumar --- sound/soc/intel/skylake/skl-debug.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/intel/skylake/skl-debug.c b/sound/soc/intel/skylake/skl-debug.c index 0a12736cf22b..969179a18fc9 100644 --- a/sound/soc/intel/skylake/skl-debug.c +++ b/sound/soc/intel/skylake/skl-debug.c @@ -605,6 +605,10 @@ static ssize_t adsp_control_write(struct file *file, while (buf[j] != '\0') { if (buf[j] == ',') { + if ((bufsize-j) > sizeof(id)) { + dev_err(d->dev, "ID buffer overflow\n"); + return -EINVAL; + } strncpy(id, &buf[j+1], (bufsize-j)); buf[j] = '\0'; tx_param = 1; -- https://clearlinux.org