clear-pkgs-linux-iot-lts2018/0544-VBS-K-fix-a-bug-due-to...

36 lines
1.1 KiB
Diff
Raw Permalink Normal View History

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
2018-10-11 02:06:46 +08:00
From: Jian Jun Chen <jian.jun.chen@intel.com>
Date: Fri, 31 Aug 2018 10:59:03 +0800
Subject: [PATCH] VBS-K: fix a bug due to incorrect check of return value of
bitmap_empty
2018-10-11 02:06:46 +08:00
When no bits are set in ioreqs_map, bitmap_empty returns 1. In this case
we can just return 0 since no virtqueues are kicked.
Signed-off-by: Jian Jun Chen <jian.jun.chen@intel.com>
Reviewed-by: Shuo Liu <shuo.a.liu@intel.com>
Reviewed-by: Yu Wang <yu1.wang@intel.com>
Reviewed-by: Zhao Yakui <yakui.zhao@intel.com>
---
drivers/vbs/vbs_rng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vbs/vbs_rng.c b/drivers/vbs/vbs_rng.c
2020-10-27 02:14:06 +08:00
index 45e17b086c29..fd2bb27af66e 100644
2018-10-11 02:06:46 +08:00
--- a/drivers/vbs/vbs_rng.c
+++ b/drivers/vbs/vbs_rng.c
@@ -256,8 +256,8 @@ static int handle_kick(int client_id, unsigned long *ioreqs_map)
int val = -1;
struct vbs_rng *rng;
- if (unlikely(bitmap_empty(ioreqs_map, VHM_REQUEST_MAX) <= 0))
- return -EINVAL;
+ if (unlikely(bitmap_empty(ioreqs_map, VHM_REQUEST_MAX)))
+ return 0;
pr_debug("%s: handle kick!\n", __func__);
--
https://clearlinux.org
2018-10-11 02:06:46 +08:00