acrn-kernel/samples/bpf
Linus Torvalds f70efe54b9 work around gcc bugs with 'asm goto' with outputs
commit 68fb3ca0e408e00db1c3f8fccdfa19e274c033be upstream.

We've had issues with gcc and 'asm goto' before, and we created a
'asm_volatile_goto()' macro for that in the past: see commits
3f0116c323 ("compiler/gcc4: Add quirk for 'asm goto' miscompilation
bug") and a9f180345f ("compiler/gcc4: Make quirk for
asm_volatile_goto() unconditional").

Then, much later, we ended up removing the workaround in commit
43c249ea0b ("compiler-gcc.h: remove ancient workaround for gcc PR
58670") because we no longer supported building the kernel with the
affected gcc versions, but we left the macro uses around.

Now, Sean Christopherson reports a new version of a very similar
problem, which is fixed by re-applying that ancient workaround.  But the
problem in question is limited to only the 'asm goto with outputs'
cases, so instead of re-introducing the old workaround as-is, let's
rename and limit the workaround to just that much less common case.

It looks like there are at least two separate issues that all hit in
this area:

 (a) some versions of gcc don't mark the asm goto as 'volatile' when it
     has outputs:

        https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98619
        https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110420

     which is easy to work around by just adding the 'volatile' by hand.

 (b) Internal compiler errors:

        https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110422

     which are worked around by adding the extra empty 'asm' as a
     barrier, as in the original workaround.

but the problem Sean sees may be a third thing since it involves bad
code generation (not an ICE) even with the manually added 'volatile'.

The same old workaround works for this case, even if this feels a
bit like voodoo programming and may only be hiding the issue.

Reported-and-tested-by: Sean Christopherson <seanjc@google.com>
Link: https://lore.kernel.org/all/20240208220604.140859-1-seanjc@google.com/
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Uros Bizjak <ubizjak@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>
Cc: Andrew Pinski <quic_apinski@quicinc.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-02-23 09:12:28 +01:00
..
.gitignore
Makefile samples: bpf: Fix cross-compiling error by using bootstrap bpftool 2022-07-15 12:01:30 -07:00
Makefile.target
README.rst
asm_goto_workaround.h work around gcc bugs with 'asm goto' with outputs 2024-02-23 09:12:28 +01:00
bpf_insn.h
cookie_uid_helper_example.c
cpustat_kern.c
cpustat_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
do_hbm_test.sh
fds_example.c samples: bpf: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE 2022-07-13 21:43:52 -07:00
hash_func01.h
hbm.c samples/bpf: Fix fout leak in hbm's run_bpf_prog 2023-05-24 17:32:38 +01:00
hbm.h
hbm_edt_kern.c
hbm_kern.h
hbm_out_kern.c
ibumad_kern.c
ibumad_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
lathist_kern.c
lathist_user.c
lwt_len_hist.sh
lwt_len_hist_kern.c
lwt_len_hist_user.c
map_perf_test_kern.c samples/bpf: Reduce syscall overhead in map_perf_test. 2022-09-05 15:33:05 +02:00
map_perf_test_user.c samples/bpf: Reduce syscall overhead in map_perf_test. 2022-09-05 15:33:05 +02:00
offwaketime_kern.c
offwaketime_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
parse_ldabs.c
parse_simple.c
parse_varlen.c
run_cookie_uid_helper_example.sh
sampleip_kern.c
sampleip_user.c
sock_example.c samples: bpf: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE 2022-07-13 21:43:52 -07:00
sock_example.h
sock_flags_kern.c
sockex1_kern.c
sockex1_user.c
sockex2_kern.c
sockex2_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
sockex3_kern.c
sockex3_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
spintest_kern.c
spintest_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
syscall_nrs.c
syscall_tp_kern.c
syscall_tp_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
task_fd_query_kern.c samples/bpf: Replace blk_account_io_done() with __blk_account_io_done() 2022-09-20 17:25:59 -07:00
task_fd_query_user.c samples/bpf: Replace blk_account_io_done() with __blk_account_io_done() 2022-09-20 17:25:59 -07:00
tc_l2_redirect.sh
tc_l2_redirect_kern.c
tc_l2_redirect_user.c
tcbpf1_kern.c
tcp_basertt_kern.c samples/bpf: Fix buffer overflow in tcp_basertt 2023-07-19 16:21:04 +02:00
tcp_bpf.readme
tcp_bufs_kern.c
tcp_clamp_kern.c
tcp_cong_kern.c
tcp_dumpstats_kern.c
tcp_iw_kern.c
tcp_rwnd_kern.c
tcp_synrto_kern.c
tcp_tos_reflect_kern.c
test_cgrp2_array_pin.c
test_cgrp2_attach.c samples: bpf: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE 2022-07-13 21:43:52 -07:00
test_cgrp2_sock.c
test_cgrp2_sock.sh
test_cgrp2_sock2.c
test_cgrp2_sock2.sh
test_cgrp2_tc.sh
test_cgrp2_tc_kern.c
test_cls_bpf.sh
test_current_task_under_cgroup_kern.c
test_current_task_under_cgroup_user.c
test_lru_dist.c samples: bpf: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE 2022-07-13 21:43:52 -07:00
test_lwt_bpf.c
test_lwt_bpf.sh
test_map_in_map_kern.c
test_map_in_map_user.c samples: bpf: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE 2022-07-13 21:43:52 -07:00
test_overhead_kprobe_kern.c
test_overhead_raw_tp_kern.c
test_overhead_tp_kern.c
test_overhead_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
test_override_return.sh
test_probe_write_user_kern.c
test_probe_write_user_user.c
trace_common.h
trace_event_kern.c
trace_event_user.c
trace_output_kern.c
trace_output_user.c
tracex1_kern.c
tracex1_user.c
tracex2_kern.c
tracex2_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
tracex3_kern.c samples/bpf: fix bio latency check with tracepoint 2023-09-13 09:42:34 +02:00
tracex3_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
tracex4_kern.c
tracex4_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
tracex5_kern.c
tracex5_user.c samples: bpf: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE 2022-07-13 21:43:52 -07:00
tracex6_kern.c samples/bpf: fix broken map lookup probe 2023-09-13 09:42:34 +02:00
tracex6_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
tracex7_kern.c
tracex7_user.c
xdp1_kern.c samples/bpf: xdp1 and xdp2 reduce XDPBUFSIZE to 60 2023-07-19 16:21:07 +02:00
xdp1_user.c samples/bpf: Fix map iteration in xdp1_user 2022-12-31 13:32:03 +01:00
xdp2_kern.c samples/bpf: xdp1 and xdp2 reduce XDPBUFSIZE to 60 2023-07-19 16:21:07 +02:00
xdp2skb_meta.sh
xdp2skb_meta_kern.c
xdp_adjust_tail_kern.c
xdp_adjust_tail_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
xdp_fwd_kern.c
xdp_fwd_user.c samples/bpf: Check detach prog exist or not in xdp_fwd 2022-06-15 17:26:20 -07:00
xdp_monitor.bpf.c
xdp_monitor_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
xdp_redirect.bpf.c
xdp_redirect_cpu.bpf.c
xdp_redirect_cpu_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
xdp_redirect_map.bpf.c samples/bpf: Fix xdp_redirect_map egress devmap prog 2022-07-11 21:14:35 -07:00
xdp_redirect_map_multi.bpf.c
xdp_redirect_map_multi_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
xdp_redirect_map_user.c samples/bpf: Fix xdp_redirect_map egress devmap prog 2022-07-11 21:14:35 -07:00
xdp_redirect_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
xdp_router_ipv4.bpf.c sample: bpf: xdp_router_ipv4: Allow the kernel to send arp requests 2022-06-02 16:26:54 -07:00
xdp_router_ipv4_user.c samples/bpf: Fix typo in xdp_router_ipv4 sample 2022-09-30 15:04:23 -07:00
xdp_rxq_info_kern.c
xdp_rxq_info_user.c samples/bpf: Detach xdp prog when program exits unexpectedly in xdp_rxq_info_user 2022-04-27 19:07:42 -07:00
xdp_sample.bpf.c
xdp_sample.bpf.h
xdp_sample_pkts_kern.c
xdp_sample_pkts_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
xdp_sample_shared.h
xdp_sample_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
xdp_sample_user.h
xdp_tx_iptunnel_common.h
xdp_tx_iptunnel_kern.c samples/bpf: fixup some tools to be able to support xdp multibuffer 2022-06-21 18:55:53 -07:00
xdp_tx_iptunnel_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00

README.rst

eBPF sample programs
====================

This directory contains a test stubs, verifier test-suite and examples
for using eBPF. The examples use libbpf from tools/lib/bpf.

Build dependencies
==================

Compiling requires having installed:
 * clang >= version 3.4.0
 * llvm >= version 3.7.1

Note that LLVM's tool 'llc' must support target 'bpf', list version
and supported targets with command: ``llc --version``

Clean and configuration
-----------------------

It can be needed to clean tools, samples or kernel before trying new arch or
after some changes (on demand)::

 make -C tools clean
 make -C samples/bpf clean
 make clean

Configure kernel, defconfig for instance::

 make defconfig

Kernel headers
--------------

There are usually dependencies to header files of the current kernel.
To avoid installing devel kernel headers system wide, as a normal
user, simply call::

 make headers_install

This will creates a local "usr/include" directory in the git/build top
level directory, that the make system automatically pickup first.

Compiling
=========

For building the BPF samples, issue the below command from the kernel
top level directory::

 make M=samples/bpf

It is also possible to call make from this directory.  This will just
hide the invocation of make as above.

Manually compiling LLVM with 'bpf' support
------------------------------------------

Since version 3.7.0, LLVM adds a proper LLVM backend target for the
BPF bytecode architecture.

By default llvm will build all non-experimental backends including bpf.
To generate a smaller llc binary one can use::

 -DLLVM_TARGETS_TO_BUILD="BPF"

We recommend that developers who want the fastest incremental builds
use the Ninja build system, you can find it in your system's package
manager, usually the package is ninja or ninja-build.

Quick sniplet for manually compiling LLVM and clang
(build dependencies are ninja, cmake and gcc-c++)::

 $ git clone https://github.com/llvm/llvm-project.git
 $ mkdir -p llvm-project/llvm/build
 $ cd llvm-project/llvm/build
 $ cmake .. -G "Ninja" -DLLVM_TARGETS_TO_BUILD="BPF;X86" \
            -DLLVM_ENABLE_PROJECTS="clang"    \
            -DCMAKE_BUILD_TYPE=Release        \
            -DLLVM_BUILD_RUNTIME=OFF
 $ ninja

It is also possible to point make to the newly compiled 'llc' or
'clang' command via redefining LLC or CLANG on the make command line::

 make M=samples/bpf LLC=~/git/llvm-project/llvm/build/bin/llc CLANG=~/git/llvm-project/llvm/build/bin/clang

Cross compiling samples
-----------------------
In order to cross-compile, say for arm64 targets, export CROSS_COMPILE and ARCH
environment variables before calling make. But do this before clean,
cofiguration and header install steps described above. This will direct make to
build samples for the cross target::

 export ARCH=arm64
 export CROSS_COMPILE="aarch64-linux-gnu-"

Headers can be also installed on RFS of target board if need to keep them in
sync (not necessarily and it creates a local "usr/include" directory also)::

 make INSTALL_HDR_PATH=~/some_sysroot/usr headers_install

Pointing LLC and CLANG is not necessarily if it's installed on HOST and have
in its targets appropriate arm64 arch (usually it has several arches).
Build samples::

 make M=samples/bpf

Or build samples with SYSROOT if some header or library is absent in toolchain,
say libelf, providing address to file system containing headers and libs,
can be RFS of target board::

 make M=samples/bpf SYSROOT=~/some_sysroot