OrgACRN
/
acrn-kernel
mirror of https://github.com/projectacrn/acrn-kernel.git
1
0
Fork 0
Code Issues Releases Wiki Activity
acrn-kernel/drivers/base
History
Matti Vaittinen e3a71d821e drivers: fwnode: fix fwnode_irq_get[_byname]() 
[ Upstream commit 39d422555e ]

The fwnode_irq_get() and the fwnode_irq_get_byname() return 0 upon
device-tree IRQ mapping failure. This is contradicting the
fwnode_irq_get_byname() function documentation and can potentially be a
source of errors like:

int probe(...) {
	...

	irq = fwnode_irq_get_byname();
	if (irq <= 0)
		return irq;

	...
}

Here we do correctly check the return value from fwnode_irq_get_byname()
but the driver probe will now return success. (There was already one
such user in-tree).

Change the fwnode_irq_get_byname() to work as documented and make also the
fwnode_irq_get() follow same common convention returning a negative errno
upon failure.

Fixes: ca0acb511c ("device property: Add fwnode_irq_get_byname")
Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Suggested-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Message-ID: <3e64fe592dc99e27ef9a0b247fc49fa26b6b8a58.1685340157.git.mazziesaccount@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
 		2023-07-19 16:21:57 +02:00
..
firmware_loader
…
power PM: domains: Move the verification of in-params from genpd_add_device() 2023-07-19 16:21:01 +02:00
regmap regmap: spi-avmm: Fix regmap_bus max_raw_write 2023-06-28 11:12:26 +02:00
test
…
Kconfig
…
Makefile
…
arch_numa.c
…
arch_topology.c
…
attribute_container.c
…
auxiliary.c
…
base.h
…
bus.c
…
cacheinfo.c drivers: base: cacheinfo: Fix shared_cpu_map changes in event of CPU hotplug 2023-06-09 10:34:17 +02:00
class.c
…
component.c drivers: base: component: fix memory leak with using debugfs_lookup() 2023-03-11 13:55:39 +01:00
container.c
…
core.c driver core: fw_devlink: Avoid spurious error message 2023-03-10 09:34:01 +01:00
cpu.c tick/nohz: Fix cpu_is_hotpluggable() by checking with nohz subsystem 2023-05-11 23:03:01 +09:00
dd.c driver core: Don't require dynamic_debug for initcall_debug probe timing 2023-05-01 08:26:27 +09:00
devcoredump.c
…
devres.c
…
devtmpfs.c
…
driver.c
…
firmware.c
…
hypervisor.c
…
init.c
…
isa.c
…
map.c
…
memory.c
…
module.c
…
node.c
…
physical_location.c driver core: location: Free struct acpi_pld_info *pld before return false 2023-03-10 09:33:33 +01:00
physical_location.h
…
pinctrl.c
…
platform-msi.c
…
platform.c platform: Provide a remove callback that returns no value 2023-05-24 17:32:43 +01:00
property.c drivers: fwnode: fix fwnode_irq_get[_byname]() 2023-07-19 16:21:57 +02:00
soc.c
…
swnode.c
…
syscore.c
…
topology.c
…
trace.c
…
trace.h
…
transport_class.c drivers: base: transport_class: fix resource leak when transport_add_device() fails 2023-03-10 09:33:34 +01:00