Xin Long 03c3a5584a sctp: add a refcnt in sctp_stream_priorities to avoid a nested loop ... [ Upstream commit 68ba446395 ] With this refcnt added in sctp_stream_priorities, we don't need to traverse all streams to check if the prio is used by other streams when freeing one stream's prio in sctp_sched_prio_free_sid(). This can avoid a nested loop (up to 65535 * 65535), which may cause a stuck as Ying reported: watchdog: BUG: soft lockup - CPU#23 stuck for 26s! [ksoftirqd/23:136] Call Trace: <TASK> sctp_sched_prio_free_sid+0xab/0x100 [sctp] sctp_stream_free_ext+0x64/0xa0 [sctp] sctp_stream_free+0x31/0x50 [sctp] sctp_association_free+0xa5/0x200 [sctp] Note that it doesn't need to use refcount_t type for this counter, as its accessing is always protected under the sock lock. v1->v2: - add a check in sctp_sched_prio_set to avoid the possible prio_head refcnt overflow. Fixes: 9ed7bfc795 ("sctp: fix memory leak in sctp_stream_outq_migrate()") Reported-by: Ying Xu <yinxu@redhat.com> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: Xin Long <lucien.xin@gmail.com> Link: https://lore.kernel.org/r/825eb0c905cb864991eba335f4a2b780e543f06b.1677085641.git.lucien.xin@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-03-11 13:55:26 +01:00
..
auth.h	…
checksum.h	…
command.h	…
constants.h	…
sctp.h	net: remove noblock parameter from recvmsg() entities	2022-04-12 15:00:25 +02:00
sm.h	…
stream_interleave.h	…
stream_sched.h	sctp: fix memory leak in sctp_stream_outq_migrate()	2022-11-29 08:30:50 -08:00
structs.h	sctp: add a refcnt in sctp_stream_priorities to avoid a nested loop	2023-03-11 13:55:26 +01:00
tsnmap.h	…
ulpevent.h	…
ulpqueue.h	…