37e3430176
Services are supposed to generate an interrupt once completed, whether or not they have do so successfully. What appears to be a bug in the system controller means that interrupts are only generated for *successful* services. Currently, the status of a service is only checked in the mpfs_mbox_rx_data() once an interrupt is received. As it turns out, this is not really helpful where the potentially buggy behaviour is present, as we'll only see the status for successes where it is moot anyway. Jassi suggested moving the check to the .tx_done() callback instead. This makes sense, as the busy bit that tx_done() is polling will be lowered on completion, regardless of whether the service passed or failed. That allows us to check the status bits for all services, whether they generate an interrupt or not & pass something more informative than -EBADMSG back to the drivers implementing individual services. Suggested-by: Jassi Brar <jassisinghbrar@gmail.com> Acked-by: Jassi Brar <jaswinder.singh@linaro.org> Tested-by: Valentina Fernandez <valentina.fernandezalanis@microchip.com> Signed-off-by: Conor Dooley <conor.dooley@microchip.com> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| apple-mailbox.c | ||
| arm_mhu.c | ||
| arm_mhu_db.c | ||
| arm_mhuv2.c | ||
| armada-37xx-rwtm-mailbox.c | ||
| bcm-flexrm-mailbox.c | ||
| bcm-pdc-mailbox.c | ||
| bcm2835-mailbox.c | ||
| hi3660-mailbox.c | ||
| hi6220-mailbox.c | ||
| imx-mailbox.c | ||
| mailbox-altera.c | ||
| mailbox-mpfs.c | ||
| mailbox-sti.c | ||
| mailbox-test.c | ||
| mailbox-xgene-slimpro.c | ||
| mailbox.c | ||
| mailbox.h | ||
| mtk-adsp-mailbox.c | ||
| mtk-cmdq-mailbox.c | ||
| omap-mailbox.c | ||
| pcc.c | ||
| pl320-ipc.c | ||
| platform_mhu.c | ||
| qcom-apcs-ipc-mailbox.c | ||
| qcom-ipcc.c | ||
| rockchip-mailbox.c | ||
| sprd-mailbox.c | ||
| stm32-ipcc.c | ||
| sun6i-msgbox.c | ||
| tegra-hsp.c | ||
| ti-msgmgr.c | ||
| zynqmp-ipi-mailbox.c | ||