Fedor Pchelkin 70d40674a5 net: openvswitch: fix flow memory leak in ovs_flow_cmd_new ... [ Upstream commit 0c598aed44 ] Syzkaller reports a memory leak of new_flow in ovs_flow_cmd_new() as it is not freed when an allocation of a key fails. BUG: memory leak unreferenced object 0xffff888116668000 (size 632): comm "syz-executor231", pid 1090, jiffies 4294844701 (age 18.871s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<00000000defa3494>] kmem_cache_zalloc include/linux/slab.h:654 [inline] [<00000000defa3494>] ovs_flow_alloc+0x19/0x180 net/openvswitch/flow_table.c:77 [<00000000c67d8873>] ovs_flow_cmd_new+0x1de/0xd40 net/openvswitch/datapath.c:957 [<0000000010a539a8>] genl_family_rcv_msg_doit+0x22d/0x330 net/netlink/genetlink.c:739 [<00000000dff3302d>] genl_family_rcv_msg net/netlink/genetlink.c:783 [inline] [<00000000dff3302d>] genl_rcv_msg+0x328/0x590 net/netlink/genetlink.c:800 [<000000000286dd87>] netlink_rcv_skb+0x153/0x430 net/netlink/af_netlink.c:2515 [<0000000061fed410>] genl_rcv+0x24/0x40 net/netlink/genetlink.c:811 [<000000009dc0f111>] netlink_unicast_kernel net/netlink/af_netlink.c:1313 [inline] [<000000009dc0f111>] netlink_unicast+0x545/0x7f0 net/netlink/af_netlink.c:1339 [<000000004a5ee816>] netlink_sendmsg+0x8e7/0xde0 net/netlink/af_netlink.c:1934 [<00000000482b476f>] sock_sendmsg_nosec net/socket.c:651 [inline] [<00000000482b476f>] sock_sendmsg+0x152/0x190 net/socket.c:671 [<00000000698574ba>] ____sys_sendmsg+0x70a/0x870 net/socket.c:2356 [<00000000d28d9e11>] ___sys_sendmsg+0xf3/0x170 net/socket.c:2410 [<0000000083ba9120>] __sys_sendmsg+0xe5/0x1b0 net/socket.c:2439 [<00000000c00628f8>] do_syscall_64+0x30/0x40 arch/x86/entry/common.c:46 [<000000004abfdcf4>] entry_SYSCALL_64_after_hwframe+0x61/0xc6 To fix this the patch rearranges the goto labels to reflect the order of object allocations and adds appropriate goto statements on the error paths. Found by Linux Verification Center (linuxtesting.org) with Syzkaller. Fixes: 68bb10101e ("openvswitch: Fix flow lookup to use unmasked key") Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Acked-by: Eelco Chaudron <echaudro@redhat.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Link: https://lore.kernel.org/r/20230201210218.361970-1-pchelkin@ispras.ru Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-02-09 11:28:11 +01:00
..
Kconfig	…
Makefile	…
actions.c	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
conntrack.c	netfilter: conntrack: Fix data-races around ct mark	2022-11-18 15:21:00 +01:00
conntrack.h	…
datapath.c	net: openvswitch: fix flow memory leak in ovs_flow_cmd_new	2023-02-09 11:28:11 +01:00
datapath.h	…
dp_notify.c	…
flow.c	…
flow.h	…
flow_netlink.c	openvswitch: Use kmalloc_size_roundup() to match ksize() usage	2022-12-31 13:32:59 +01:00
flow_netlink.h	…
flow_table.c	…
flow_table.h	…
meter.c	net: openvswitch: allow metering in non-initial user namespace	2022-09-27 11:31:36 +02:00
meter.h	…
openvswitch_trace.c	…
openvswitch_trace.h	…
vport-geneve.c	…
vport-gre.c	…
vport-internal_dev.c	openvswitch: Change the return type for vport_ops.send function hook to int	2022-09-19 18:28:50 -07:00
vport-internal_dev.h	…
vport-netdev.c	…
vport-netdev.h	…
vport-vxlan.c	…
vport.c	…
vport.h	openvswitch: Change the return type for vport_ops.send function hook to int	2022-09-19 18:28:50 -07:00