Sebastian Andrzej Siewior 6cf0d1d5a5 bpf: Assign bpf_tramp_run_ctx::saved_run_ctx before recursion check. ... [ Upstream commit 6764e767f4 ] __bpf_prog_enter_recur() assigns bpf_tramp_run_ctx::saved_run_ctx before performing the recursion check which means in case of a recursion __bpf_prog_exit_recur() uses the previously set bpf_tramp_run_ctx::saved_run_ctx value. __bpf_prog_enter_sleepable_recur() assigns bpf_tramp_run_ctx::saved_run_ctx after the recursion check which means in case of a recursion __bpf_prog_exit_sleepable_recur() uses an uninitialized value. This does not look right. If I read the entry trampoline code right, then bpf_tramp_run_ctx isn't initialized upfront. Align __bpf_prog_enter_sleepable_recur() with __bpf_prog_enter_recur() and set bpf_tramp_run_ctx::saved_run_ctx before the recursion check is made. Remove the assignment of saved_run_ctx in kern_sys_bpf() since it happens a few cycles later. Fixes: e384c7b7b4 ("bpf, x86: Create bpf_tramp_run_ctx on the caller thread's stack") Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Jiri Olsa <jolsa@kernel.org> Link: https://lore.kernel.org/bpf/20230830080405.251926-3-bigeasy@linutronix.de Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-09-19 12:28:03 +02:00
..
preload	…
Kconfig	…
Makefile	…
arraymap.c	…
bloom_filter.c	…
bpf_inode_storage.c	…
bpf_iter.c	…
bpf_local_storage.c	…
bpf_lru_list.c	bpf: Address KCSAN report on bpf_lru_list	2023-07-27 08:50:34 +02:00
bpf_lru_list.h	bpf: Address KCSAN report on bpf_lru_list	2023-07-27 08:50:34 +02:00
bpf_lsm.c	…
bpf_struct_ops.c	…
bpf_struct_ops_types.h	…
bpf_task_storage.c	…
btf.c	bpf: Fix an error in verifying a field in a union	2023-09-13 09:42:30 +02:00
cgroup.c	bpf: Don't EFAULT for {g,s}setsockopt with wrong optlen	2023-07-19 16:21:05 +02:00
cgroup_iter.c	cgroup: bpf: use cgroup_lock()/cgroup_unlock() wrappers	2023-06-21 16:00:51 +02:00
core.c	…
cpumap.c	bpf, cpumap: Make sure kthread is running before map update returns	2023-08-11 12:08:23 +02:00
devmap.c	…
disasm.c	…
disasm.h	…
dispatcher.c	…
hashtab.c	bpf: fix a memory leak in the LRU and LRU_PERCPU hash maps	2023-05-30 14:03:21 +01:00
helpers.c	…
inode.c	…
link_iter.c	…
local_storage.c	cgroup: bpf: use cgroup_lock()/cgroup_unlock() wrappers	2023-06-21 16:00:51 +02:00
lpm_trie.c	…
map_in_map.c	bpf: Fix elem_size not being set for inner maps	2023-06-14 11:15:17 +02:00
map_in_map.h	…
map_iter.c	…
memalloc.c	…
mmap_unlock_work.h	…
net_namespace.c	…
offload.c	…
percpu_freelist.c	…
percpu_freelist.h	…
prog_iter.c	…
queue_stack_maps.c	…
reuseport_array.c	…
ringbuf.c	…
stackmap.c	…
syscall.c	bpf: Assign bpf_tramp_run_ctx::saved_run_ctx before recursion check.	2023-09-19 12:28:03 +02:00
sysfs_btf.c	…
task_iter.c	…
tnum.c	…
trampoline.c	bpf: Assign bpf_tramp_run_ctx::saved_run_ctx before recursion check.	2023-09-19 12:28:03 +02:00
verifier.c	bpf: Fix issue in verifying allow_ptr_leaks	2023-09-13 09:43:02 +02:00