Menglong Dong 9cb252c4c1 net: skb: export skb drop reaons to user by TRACE_DEFINE_ENUM ... As Eric reported, the 'reason' field is not presented when trace the kfree_skb event by perf: $ perf record -e skb:kfree_skb -a sleep 10 $ perf script ip_defrag 14605 [021] 221.614303: skb:kfree_skb: skbaddr=0xffff9d2851242700 protocol=34525 location=0xffffffffa39346b1 reason: The cause seems to be passing kernel address directly to TP_printk(), which is not right. As the enum 'skb_drop_reason' is not exported to user space through TRACE_DEFINE_ENUM(), perf can't get the drop reason string from the 'reason' field, which is a number. Therefore, we introduce the macro DEFINE_DROP_REASON(), which is used to define the trace enum by TRACE_DEFINE_ENUM(). With the help of DEFINE_DROP_REASON(), now we can remove the auto-generate that we introduced in the commit ec43908dd5 ("net: skb: use auto-generation to convert skb drop reason to string"), and define the string array 'drop_reasons'. Hmmmm...now we come back to the situation that have to maintain drop reasons in both enum skb_drop_reason and DEFINE_DROP_REASON. But they are both in dropreason.h, which makes it easier. After this commit, now the format of kfree_skb is like this: $ cat /tracing/events/skb/kfree_skb/format name: kfree_skb ID: 1524 format: field:unsigned short common_type; offset:0; size:2; signed:0; field:unsigned char common_flags; offset:2; size:1; signed:0; field:unsigned char common_preempt_count; offset:3; size:1; signed:0; field:int common_pid; offset:4; size:4; signed:1; field:void * skbaddr; offset:8; size:8; signed:0; field:void * location; offset:16; size:8; signed:0; field:unsigned short protocol; offset:24; size:2; signed:0; field:enum skb_drop_reason reason; offset:28; size:4; signed:0; print fmt: "skbaddr=%p protocol=%u location=%p reason: %s", REC->skbaddr, REC->protocol, REC->location, __print_symbolic(REC->reason, { 1, "NOT_SPECIFIED" }, { 2, "NO_SOCKET" } ...... Fixes: ec43908dd5 ("net: skb: use auto-generation to convert skb drop reason to string") Link: https://lore.kernel.org/netdev/CANn89i+bx0ybvE55iMYf5GJM48WwV1HNpdm9Q6t-HaEstqpCSA@mail.gmail.com/ Reported-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Menglong Dong <imagedong@tencent.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2022-09-07 15:28:08 +01:00
..
9p	9p: Add client parameter to p9_req_put()	2022-07-09 14:38:35 +09:00
bluetooth	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-07-28 18:21:16 -07:00
caif	…
iucv	…
netfilter	netfilter: remove nf_conntrack_helper sysctl and modparam toggles	2022-08-31 12:12:32 +02:00
netns	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf	2022-09-02 19:38:25 -07:00
nfc	…
phonet	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
sctp	…
tc_act	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-05-12 16:15:30 -07:00
6lowpan.h	…
Space.h	…
act_api.h	…
addrconf.h	ipv6/addrconf: fix a null-ptr-deref bug for ip6_ptr	2022-07-28 10:42:44 -07:00
af_ieee802154.h	…
af_rxrpc.h	rxrpc: Remove rxrpc_get_reply_time() which is no longer used	2022-09-01 11:44:13 +01:00
af_unix.h	af_unix: Remove unix_table_locks.	2022-06-22 12:59:43 +01:00
af_vsock.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
ah.h	…
amt.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
arp.h	…
atmclip.h	…
ax25.h	ax25: fix incorrect dev_tracker usage	2022-07-28 22:06:15 -07:00
ax88796.h	ax88796: Fix some typo in a comment	2022-08-09 22:14:02 -07:00
bareudp.h	…
bond_3ad.h	bonding: 3ad: make ad_ticks_per_sec a const	2022-08-22 18:30:24 -07:00
bond_alb.h	…
bond_options.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
bonding.h	net: bonding: replace dev_trans_start() with the jiffies of the last ARP/NS	2022-08-03 19:20:12 -07:00
bpf_sk_storage.h	…
busy_poll.h	net: Fix a data-race around sysctl_net_busy_poll.	2022-08-24 13:46:58 +01:00
calipso.h	…
cfg80211-wext.h	…
cfg80211.h	wifi: nl80211: add MLO link ID to the NL80211_CMD_FRAME TX API	2022-07-22 14:28:33 +02:00
cfg802154.h	net: wrap the wireless pointers in struct net_device in an ifdef	2022-05-22 21:51:54 +01:00
checksum.h	…
cipso_ipv4.h	…
cls_cgroup.h	…
codel.h	…
codel_impl.h	…
codel_qdisc.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
compat.h	net: copy from user before calling __get_compat_msghdr	2022-07-24 18:39:17 -06:00
datalink.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
dcbevent.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
dcbnl.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
devlink.h	devlink: introduce framework for selftests	2022-07-28 21:56:53 -07:00
dn.h	…
dn_dev.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
dn_fib.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
dn_neigh.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
dn_nsp.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
dn_route.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
dropreason.h	net: skb: export skb drop reaons to user by TRACE_DEFINE_ENUM	2022-09-07 15:28:08 +01:00
dsa.h	net: dsa: tag_ksz: add tag handling for Microchip LAN937x	2022-07-02 16:34:05 +01:00
dsfield.h	…
dst.h	…
dst_cache.h	…
dst_metadata.h	…
dst_ops.h	…
erspan.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
esp.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
espintcp.h	…
ethoc.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
failover.h	…
fib_notifier.h	…
fib_rules.h	…
firewire.h	firewire: net: Make use of get_unaligned_be48(), put_unaligned_be48()	2022-07-28 22:21:54 -07:00
flow.h	…
flow_dissector.h	flow_dissector: Add PPPoE dissectors	2022-07-26 09:49:12 -07:00
flow_offload.h	flow_offload: Introduce flow_match_pppoe	2022-07-26 10:49:27 -07:00
fou.h	…
fq.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
fq_impl.h	net/fq_impl: Use the bitmap API to allocate bitmaps	2022-07-11 19:49:38 -07:00
garp.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
gen_stats.h	…
genetlink.h	net: add missing kdoc for struct genl_multicast_group::flags	2022-08-11 09:26:04 -07:00
geneve.h	…
gre.h	…
gro.h	net: Fix a data-race around gro_normal_batch.	2022-08-24 13:46:58 +01:00
gro_cells.h	…
gtp.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
gue.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
hwbm.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
icmp.h	…
ieee80211_radiotap.h	…
ieee802154_netdev.h	…
if_inet6.h	…
ife.h	…
ila.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
inet6_connection_sock.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
inet6_hashtables.h	net: allow unbound socket for packets in VRF when tcp_l3mdev_accept set	2022-07-29 11:58:54 +01:00
inet_common.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
inet_connection_sock.h	Revert "tcp: change pingpong threshold to 3"	2022-07-22 15:09:10 -07:00
inet_dscp.h	…
inet_ecn.h	…
inet_frag.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
inet_hashtables.h	net: allow unbound socket for packets in VRF when tcp_l3mdev_accept set	2022-07-29 11:58:54 +01:00
inet_sock.h	net: allow unbound socket for packets in VRF when tcp_l3mdev_accept set	2022-07-29 11:58:54 +01:00
inet_timewait_sock.h	Revert "tcp/dccp: get rid of inet_twsk_purge()"	2022-05-13 12:24:12 +01:00
inetpeer.h	…
ioam6.h	…
ip.h	ip: Fix data-races around sysctl_ip_prot_sock.	2022-07-20 10:14:49 +01:00
ip6_checksum.h	…
ip6_fib.h	…
ip6_route.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
ip6_tunnel.h	ip_gre, ip6_gre: Fix race condition on o_seqno in collect_md mode	2022-04-25 11:40:45 +01:00
ip_fib.h	…
ip_tunnels.h	ip_tunnel: Respect tunnel key's "flow_flags" in IP tunnels	2022-08-18 21:18:28 +02:00
ip_vs.h	…
ipcomp.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
ipconfig.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
ipv6.h	ipv6: Fix signed integer overflow in __ip6_append_data	2022-06-08 10:56:43 -07:00
ipv6_frag.h	…
ipv6_stubs.h	…
iw_handler.h	…
kcm.h	…
l3mdev.h	…
lag.h	…
lapb.h	…
lib80211.h	…
llc.h	…
llc_c_ac.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
llc_c_ev.h	…
llc_c_st.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
llc_conn.h	…
llc_if.h	…
llc_pdu.h	…
llc_s_ac.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
llc_s_ev.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
llc_s_st.h	add missing includes and forward declarations to networking includes under linux/	2022-07-28 11:29:36 +02:00
llc_sap.h	…
lwtunnel.h	…
mac80211.h	wifi: mac80211: add macros to loop over active links	2022-07-22 14:28:47 +02:00
mac802154.h	net: mac802154: Create an error helper for asynchronous offloading errors	2022-04-25 20:51:12 +02:00
macsec.h	…
mctp.h	…
mctpdevice.h	…
mip6.h	…
mld.h	…
mpls.h	…
mpls_iptunnel.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
mptcp.h	mptcp, btf: Add struct mptcp_sock definition when CONFIG_MPTCP is disabled	2022-08-08 15:30:45 +02:00
mrp.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
ncsi.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
ndisc.h	…
neighbour.h	neighbour: make proxy_queue.qlen limit per-device	2022-08-15 11:25:09 +01:00
net_debug.h	net: add CONFIG_DEBUG_NET	2022-05-11 12:43:10 +01:00
net_failover.h	…
net_namespace.h	netfilter: nf_flow_table: count pending offload workqueue tasks	2022-07-11 16:25:14 +02:00
net_ratelimit.h	…
net_trackers.h	…
netevent.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
netlabel.h	…
netlink.h	…
netprio_cgroup.h	…
netrom.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
nexthop.h	…
nl802154.h	…
nsh.h	…
p8022.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
page_pool.h	…
pie.h	…
ping.h	…
pkt_cls.h	net/sched: remove return value of unregister_tcf_proto_ops	2022-07-13 14:46:59 +01:00
pkt_sched.h	net: sched: provide shim definitions for taprio_offload_{get,free}	2022-07-05 17:50:38 -07:00
pptp.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
protocol.h	tcp/udp: Make early_demux back namespacified.	2022-07-15 18:50:35 -07:00
psample.h	…
psnap.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
raw.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-07-14 15:27:35 -07:00
rawv6.h	raw: convert raw sockets to RCU	2022-06-19 10:00:02 +01:00
red.h	…
regulatory.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
request_sock.h	…
rose.h	net: rose: add netdev ref tracker to 'struct rose_sock'	2022-08-01 11:59:23 -07:00
route.h	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2022-07-25 13:25:39 +01:00
rpl.h	…
rsi_91x.h	…
rtnetlink.h	…
rtnh.h	…
sch_generic.h	net/sched: remove qdisc_root_lock() helper	2022-07-19 17:14:55 -07:00
scm.h	…
secure_seq.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
seg6.h	…
seg6_hmac.h	…
seg6_local.h	…
selftests.h	…
slhc_vj.h	…
smc.h	net/smc: Pass on DMBE bit mask in IRQ handler	2022-07-27 13:24:42 +01:00
snmp.h	…
sock.h	net: Fix suspicious RCU usage in bpf_sk_reuseport_detach()	2022-08-17 16:42:59 -07:00
sock_reuseport.h	…
stp.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
strparser.h	tls: rx: remove the message decrypted tracking	2022-07-18 11:24:10 +01:00
switchdev.h	net: switchdev: add reminder near struct switchdev_notifier_fdb_info	2022-06-29 20:37:36 -07:00
tcp.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-07-28 18:21:16 -07:00
tcp_states.h	…
timewait_sock.h	…
tipc.h	…
tls.h	net/tls: Use RCU API to access tls_ctx->netdev	2022-08-10 22:58:43 -07:00
tls_toe.h	…
transp_v6.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
tso.h	…
tun_proto.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
udp.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-07-21 13:03:39 -07:00
udp_tunnel.h	rxrpc: Fix ICMP/ICMP6 error handling	2022-09-01 11:42:12 +01:00
udplite.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
vsock_addr.h	…
vxlan.h	…
wext.h	…
x25.h	…
x25device.h	…
xdp.h	…
xdp_priv.h	net: add missing includes and forward declarations under net/	2022-07-22 12:53:22 +01:00
xdp_sock.h	…
xdp_sock_drv.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-08-03 09:04:55 +02:00
xfrm.h	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2022-07-25 13:25:39 +01:00
xsk_buff_pool.h	xsk: Fix possible crash when multiple sockets are created	2022-04-26 16:19:54 +02:00