crypto: aspeed - fix type warnings

This patch fixes following warnings:

1. sparse: incorrect type in assignment (different base types)
Fix: change to __le32 type.
2. sparse: cast removes address space '__iomem' of expression
Fix: use readb to avoid dereferencing the memory.

Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Neal Liu 2023-02-03 11:35:12 +08:00 committed by Herbert Xu
parent acd4045db6
commit eaf05e829f
1 changed files with 4 additions and 4 deletions

View File

@ -252,7 +252,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf,
enum aspeed_rsa_key_mode mode) enum aspeed_rsa_key_mode mode)
{ {
const u8 *src = xbuf; const u8 *src = xbuf;
u32 *dw_buf = (u32 *)buf; __le32 *dw_buf = buf;
int nbits, ndw; int nbits, ndw;
int i, j, idx; int i, j, idx;
u32 data = 0; u32 data = 0;
@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf,
static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev) static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev)
{ {
struct akcipher_request *req = acry_dev->req; struct akcipher_request *req = acry_dev->req;
u8 *sram_buffer = (u8 *)acry_dev->acry_sram; u8 __iomem *sram_buffer = acry_dev->acry_sram;
struct scatterlist *out_sg = req->dst; struct scatterlist *out_sg = req->dst;
static u8 dram_buffer[ASPEED_ACRY_SRAM_MAX_LEN]; static u8 dram_buffer[ASPEED_ACRY_SRAM_MAX_LEN];
int leading_zero = 1; int leading_zero = 1;
@ -321,11 +321,11 @@ static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev)
for (j = ASPEED_ACRY_SRAM_MAX_LEN - 1; j >= 0; j--) { for (j = ASPEED_ACRY_SRAM_MAX_LEN - 1; j >= 0; j--) {
data_idx = acry_dev->data_byte_mapping[j]; data_idx = acry_dev->data_byte_mapping[j];
if (sram_buffer[data_idx] == 0 && leading_zero) { if (readb(sram_buffer + data_idx) == 0 && leading_zero) {
result_nbytes--; result_nbytes--;
} else { } else {
leading_zero = 0; leading_zero = 0;
dram_buffer[i] = sram_buffer[data_idx]; dram_buffer[i] = readb(sram_buffer + data_idx);
i++; i++;
} }
} }