OrgACRN
/
acrn-kernel
mirror of https://github.com/projectacrn/acrn-kernel.git
1
0
Fork 0
Code Issues Releases Wiki Activity

rapidio: rio: fix possible name leak in rio_register_mport() 

If device_register() returns error, the name allocated by dev_set_name()
need be freed.  It should use put_device() to give up the reference in the
error path, so that the name can be freed in kobject_cleanup(), and
list_del() is called to delete the port from rio_mports.

Link: https://lkml.kernel.org/r/20221114152636.2939035-3-yangyingliang@huawei.com
Fixes: 2aaf308b95 ("rapidio: rework device hierarchy and introduce mport class of devices")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Cc: Alexandre Bounine <alex.bou9@gmail.com>
Cc: Matt Porter <mporter@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Yang Yingliang 2022-11-14 23:26:36 +08:00 committed by Andrew Morton
parent f9574cd486
commit e92a216d16
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/rapidio/rio.c
View File

@ -2186,11 +2186,16 @@ int rio_register_mport(struct rio_mport *port)
atomic_set(&port->state, RIO_DEVICE_RUNNING); atomic_set(&port->state, RIO_DEVICE_RUNNING);
res = device_register(&port->dev); res = device_register(&port->dev);
if (res) if (res) {
dev_err(&port->dev, "RIO: mport%d registration failed ERR=%d\n", dev_err(&port->dev, "RIO: mport%d registration failed ERR=%d\n",
port->id, res); port->id, res);
else mutex_lock(&rio_mport_list_lock);
list_del(&port->node);
mutex_unlock(&rio_mport_list_lock);
put_device(&port->dev);
} else {
dev_dbg(&port->dev, "RIO: registered mport%d\n", port->id); dev_dbg(&port->dev, "RIO: registered mport%d\n", port->id);
}
return res; return res;
} }