perf auxtrace: Fix address filter symbol name match for modules
For modules, names from kallsyms__parse() contain the module name which
meant that module symbols did not match exactly by name.
Fix by matching the name string up to the separating tab character.
Fixes: 1b36c03e35
("perf record: Add support for using symbols in address filters")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20221026072736.2982-1-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
parent
831c05a762
commit
cba04f3136
|
@ -2325,11 +2325,19 @@ struct sym_args {
|
||||||
bool near;
|
bool near;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
static bool kern_sym_name_match(const char *kname, const char *name)
|
||||||
|
{
|
||||||
|
size_t n = strlen(name);
|
||||||
|
|
||||||
|
return !strcmp(kname, name) ||
|
||||||
|
(!strncmp(kname, name, n) && kname[n] == '\t');
|
||||||
|
}
|
||||||
|
|
||||||
static bool kern_sym_match(struct sym_args *args, const char *name, char type)
|
static bool kern_sym_match(struct sym_args *args, const char *name, char type)
|
||||||
{
|
{
|
||||||
/* A function with the same name, and global or the n'th found or any */
|
/* A function with the same name, and global or the n'th found or any */
|
||||||
return kallsyms__is_function(type) &&
|
return kallsyms__is_function(type) &&
|
||||||
!strcmp(name, args->name) &&
|
kern_sym_name_match(name, args->name) &&
|
||||||
((args->global && isupper(type)) ||
|
((args->global && isupper(type)) ||
|
||||||
(args->selected && ++(args->cnt) == args->idx) ||
|
(args->selected && ++(args->cnt) == args->idx) ||
|
||||||
(!args->global && !args->selected));
|
(!args->global && !args->selected));
|
||||||
|
|
Loading…
Reference in New Issue