OrgACRN
/
acrn-kernel
mirror of https://github.com/projectacrn/acrn-kernel.git
1
0
Fork 0
Code Issues Releases Wiki Activity

xsk: Improve xdp_do_redirect() error codes 

The error codes returned by xdp_do_redirect() when redirecting a frame
to an AF_XDP socket has not been very useful. A driver could not
distinguish between different errors. Prior this change the following
codes where used:

Socket not bound or incorrect queue/netdev: EINVAL
XDP frame/AF_XDP buffer size mismatch: ENOSPC
Could not allocate buffer (copy mode): ENOSPC
AF_XDP Rx buffer full: ENOSPC

After this change:

Socket not bound or incorrect queue/netdev: EINVAL
XDP frame/AF_XDP buffer size mismatch: ENOSPC
Could not allocate buffer (copy mode): ENOMEM
AF_XDP Rx buffer full: ENOBUFS

An AF_XDP zero-copy driver can now potentially determine if the
failure was due to a full Rx buffer, and if so stop processing more
frames, yielding to the userland AF_XDP application.

Signed-off-by: Björn Töpel <bjorn@kernel.org>
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Link: https://lore.kernel.org/bpf/20220413153015.453864-2-maciej.fijalkowski@intel.com
This commit is contained in:
Björn Töpel 2022-04-13 17:30:02 +02:00 committed by Daniel Borkmann
parent 241d50ec5d
commit c6c1f11b69
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/xdp/xsk.c
View File

@ -184,7 +184,7 @@ static int __xsk_rcv(struct xdp_sock *xs, struct xdp_buff *xdp)
xsk_xdp = xsk_buff_alloc(xs->pool); xsk_xdp = xsk_buff_alloc(xs->pool);
if (!xsk_xdp) { if (!xsk_xdp) {
xs->rx_dropped++; xs->rx_dropped++;
return -ENOSPC; return -ENOMEM;
} }
xsk_copy_xdp(xsk_xdp, xdp, len); xsk_copy_xdp(xsk_xdp, xdp, len);

2
net/xdp/xsk_queue.h
View File

@ -382,7 +382,7 @@ static inline int xskq_prod_reserve_desc(struct xsk_queue *q,
u32 idx; u32 idx;
if (xskq_prod_is_full(q)) if (xskq_prod_is_full(q))
return -ENOSPC; return -ENOBUFS;
/* A, matches D */ /* A, matches D */
idx = q->cached_prod++ & q->ring_mask; idx = q->cached_prod++ & q->ring_mask;