fpga: stratix10-soc: Fix return value check in s10_ops_write_init()
commit65ea840afd
upstream. In case of error, the function stratix10_svc_allocate_memory() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes:e7eef1d763
("fpga: add intel stratix10 soc fpga manager driver") Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> Reviewed-by: Russ Weight <russell.h.weight@intel.com> Cc: stable@vger.kernel.org Acked-by: Xu Yilun <yilun.xu@intel.com> Link: https://lore.kernel.org/r/20221126071430.19540-1-zhengyongjun3@huawei.com Signed-off-by: Xu Yilun <yilun.xu@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
74cff472d3
commit
b10990bee7
|
@ -213,9 +213,9 @@ static int s10_ops_write_init(struct fpga_manager *mgr,
|
||||||
/* Allocate buffers from the service layer's pool. */
|
/* Allocate buffers from the service layer's pool. */
|
||||||
for (i = 0; i < NUM_SVC_BUFS; i++) {
|
for (i = 0; i < NUM_SVC_BUFS; i++) {
|
||||||
kbuf = stratix10_svc_allocate_memory(priv->chan, SVC_BUF_SIZE);
|
kbuf = stratix10_svc_allocate_memory(priv->chan, SVC_BUF_SIZE);
|
||||||
if (!kbuf) {
|
if (IS_ERR(kbuf)) {
|
||||||
s10_free_buffers(mgr);
|
s10_free_buffers(mgr);
|
||||||
ret = -ENOMEM;
|
ret = PTR_ERR(kbuf);
|
||||||
goto init_done;
|
goto init_done;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue