OrgACRN
/
acrn-kernel
mirror of https://github.com/projectacrn/acrn-kernel.git
1
0
Fork 0
Code Issues Releases Wiki Activity

greybus: svc: clean up link configuration hack at hello 

Commit ee2f2074fd ("greybus: svc: reconfig APBridgeA-Switch link to
handle required load") added a temporary hack which reconfigures the
link at HELLO by abusing the deferred request processing mechanism.

Restructure the HELLO request processing so that the link-configuration
work is queued before creating the debugfs files and add a comment
explaining why it's there.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20220202113347.1288-4-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold 2022-02-02 12:33:47 +01:00 committed by Greg Kroah-Hartman
parent 5f648e00f5
commit a74e7263b5
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/greybus/svc.c
View File

@ -864,16 +864,19 @@ static int gb_svc_hello(struct gb_operation *op)
goto err_deregister_svc;
}
gb_svc_debugfs_init(svc);
/*
* FIXME: This is a temporary hack to reconfigure the link at HELLO
* (which abuses the deferred request processing mechanism).
*/
ret = gb_svc_queue_deferred_request(op);
if (ret)
goto err_remove_debugfs;
goto err_destroy_watchdog;
gb_svc_debugfs_init(svc);
return 0;
err_remove_debugfs:
gb_svc_debugfs_exit(svc);
err_destroy_watchdog:
gb_svc_watchdog_destroy(svc);
err_deregister_svc:
device_del(&svc->dev);