hwmon: (xgene) Fix ioremap and memremap leak
[ Upstream commit 813cc94c78
]
Smatch reports:
drivers/hwmon/xgene-hwmon.c:757 xgene_hwmon_probe() warn:
'ctx->pcc_comm_addr' from ioremap() not released on line: 757.
This is because in drivers/hwmon/xgene-hwmon.c:701 xgene_hwmon_probe(),
ioremap and memremap is not released, which may cause a leak.
To fix this, ioremap and memremap is modified to devm_ioremap and
devm_memremap.
Signed-off-by: Tianyi Jing <jingfelix@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Link: https://lore.kernel.org/r/20230318143851.2191625-1-jingfelix@hust.edu.cn
[groeck: Fixed formatting and subject]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
f2226c840f
commit
9d482a09ac
|
@ -698,14 +698,14 @@ static int xgene_hwmon_probe(struct platform_device *pdev)
|
|||
ctx->comm_base_addr = pcc_chan->shmem_base_addr;
|
||||
if (ctx->comm_base_addr) {
|
||||
if (version == XGENE_HWMON_V2)
|
||||
ctx->pcc_comm_addr = (void __force *)ioremap(
|
||||
ctx->comm_base_addr,
|
||||
pcc_chan->shmem_size);
|
||||
ctx->pcc_comm_addr = (void __force *)devm_ioremap(&pdev->dev,
|
||||
ctx->comm_base_addr,
|
||||
pcc_chan->shmem_size);
|
||||
else
|
||||
ctx->pcc_comm_addr = memremap(
|
||||
ctx->comm_base_addr,
|
||||
pcc_chan->shmem_size,
|
||||
MEMREMAP_WB);
|
||||
ctx->pcc_comm_addr = devm_memremap(&pdev->dev,
|
||||
ctx->comm_base_addr,
|
||||
pcc_chan->shmem_size,
|
||||
MEMREMAP_WB);
|
||||
} else {
|
||||
dev_err(&pdev->dev, "Failed to get PCC comm region\n");
|
||||
rc = -ENODEV;
|
||||
|
|
Loading…
Reference in New Issue