OrgACRN
/
acrn-kernel
mirror of https://github.com/projectacrn/acrn-kernel.git
1
0
Fork 0
Code Issues Releases Wiki Activity

applicom: Fix PCI device refcount leak in applicom_init() 

[ Upstream commit ce4273d89c ]

As comment of pci_get_class() says, it returns a pci_device with its
refcount increased and decreased the refcount for the input parameter
@from if it is not NULL.

If we break the loop in applicom_init() with 'dev' not NULL, we need to
call pci_dev_put() to decrease the refcount. Add the missing
pci_dev_put() to avoid refcount leak.

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Link: https://lore.kernel.org/r/20221122114035.24194-1-wangxiongfeng2@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Xiongfeng Wang 2022-11-22 19:40:35 +08:00 committed by Greg Kroah-Hartman
parent 23b534e82d
commit 959dd00ed4
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/char/applicom.c
View File

@ -197,8 +197,10 @@ static int __init applicom_init(void)
if (!pci_match_id(applicom_pci_tbl, dev)) if (!pci_match_id(applicom_pci_tbl, dev))
continue; continue;
if (pci_enable_device(dev)) if (pci_enable_device(dev)) {
pci_dev_put(dev);
return -EIO; return -EIO;
}
RamIO = ioremap(pci_resource_start(dev, 0), LEN_RAM_IO); RamIO = ioremap(pci_resource_start(dev, 0), LEN_RAM_IO);
@ -207,6 +209,7 @@ static int __init applicom_init(void)
"space at 0x%llx\n", "space at 0x%llx\n",
(unsigned long long)pci_resource_start(dev, 0)); (unsigned long long)pci_resource_start(dev, 0));
pci_disable_device(dev); pci_disable_device(dev);
pci_dev_put(dev);
return -EIO; return -EIO;
} }